public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ZOOM2 Add serial support.
Date: Wed, 01 Apr 2009 23:36:37 +0200	[thread overview]
Message-ID: <20090401213637.BFD9F83797DC@gemini.denx.de> (raw)
In-Reply-To: <49D3D262.5010602@windriver.com>

Dear Tom,

In message <49D3D262.5010602@windriver.com> you wrote:
>
> >> diff --git a/include/serial.h b/include/serial.h
> >> index e3d8b36..aca5221 100644
> >> --- a/include/serial.h
> >> +++ b/include/serial.h
> >> @@ -42,6 +42,13 @@ extern struct serial_device s3c24xx_serial1_device;
> >>  extern struct serial_device s3c24xx_serial2_device;
> >>  #endif
> >>  
> >> +#if defined(CONFIG_OMAP3_ZOOM2)
> >> +extern struct serial_device zoom2_serial_device0;
> >> +extern struct serial_device zoom2_serial_device1;
> >> +extern struct serial_device zoom2_serial_device2;
> >> +extern struct serial_device zoom2_serial_device3;
> >> +#endif
> >> +
> >
> > Please don't add such strictly board-specific code to global header
> > files.
> >   
> The other boards that do CONFIG_SERIAL_MULTI do the same thing.
> Can I have a pass on this ?

Hm.. well, OK.

We should try to fnd a better solution, though. This doesn't scale
well.

Ideas welcome.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'm a soldier, not a diplomat.  I can only tell the truth.
	-- Kirk, "Errand of Mercy", stardate 3198.9

  reply	other threads:[~2009-04-01 21:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-01 16:11 [U-Boot] [PATCH] ZOOM2 Add initial support for Zoom2 Tom Rix
2009-04-01 16:11 ` [U-Boot] [PATCH] ZOOM2 Mux changes to support zoom2 configuration Tom Rix
2009-04-01 16:11   ` [U-Boot] [PATCH] ZOOM2 Add support for debug board detection Tom Rix
2009-04-01 16:11     ` [U-Boot] [PATCH] ZOOM2 Add serial support Tom Rix
2009-04-01 16:11       ` [U-Boot] [PATCH] ZOOM2 Add led support Tom Rix
2009-04-01 20:25       ` [U-Boot] [PATCH] ZOOM2 Add serial support Wolfgang Denk
2009-04-01 20:45         ` Tom
2009-04-01 21:36           ` Wolfgang Denk [this message]
2009-04-01 20:21     ` [U-Boot] [PATCH] ZOOM2 Add support for debug board detection Wolfgang Denk
2009-04-01 19:51 ` [U-Boot] [PATCH] ZOOM2 Add initial support for Zoom2 Scott Wood
2009-04-01 20:46   ` Tom
2009-04-01 20:19 ` Wolfgang Denk
2009-04-02  0:53   ` Tom
  -- strict thread matches above, loose matches on Subject: below --
2009-04-01 19:11 [U-Boot] [PATCH] ZOOM2 Add serial support Tom Rix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090401213637.BFD9F83797DC@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox