From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 01 Apr 2009 23:36:37 +0200 Subject: [U-Boot] [PATCH] ZOOM2 Add serial support. In-Reply-To: <49D3D262.5010602@windriver.com> References: <1238602273-27252-1-git-send-email-Tom.Rix@windriver.com> <1238602273-27252-2-git-send-email-Tom.Rix@windriver.com> <1238602273-27252-3-git-send-email-Tom.Rix@windriver.com> <1238602273-27252-4-git-send-email-Tom.Rix@windriver.com> <20090401202532.6C88183797DC@gemini.denx.de> <49D3D262.5010602@windriver.com> Message-ID: <20090401213637.BFD9F83797DC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Tom, In message <49D3D262.5010602@windriver.com> you wrote: > > >> diff --git a/include/serial.h b/include/serial.h > >> index e3d8b36..aca5221 100644 > >> --- a/include/serial.h > >> +++ b/include/serial.h > >> @@ -42,6 +42,13 @@ extern struct serial_device s3c24xx_serial1_device; > >> extern struct serial_device s3c24xx_serial2_device; > >> #endif > >> > >> +#if defined(CONFIG_OMAP3_ZOOM2) > >> +extern struct serial_device zoom2_serial_device0; > >> +extern struct serial_device zoom2_serial_device1; > >> +extern struct serial_device zoom2_serial_device2; > >> +extern struct serial_device zoom2_serial_device3; > >> +#endif > >> + > > > > Please don't add such strictly board-specific code to global header > > files. > > > The other boards that do CONFIG_SERIAL_MULTI do the same thing. > Can I have a pass on this ? Hm.. well, OK. We should try to fnd a better solution, though. This doesn't scale well. Ideas welcome. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I'm a soldier, not a diplomat. I can only tell the truth. -- Kirk, "Errand of Mercy", stardate 3198.9