From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Macronix MX25xx MTD SPI flash driver
Date: Mon, 6 Apr 2009 07:04:41 -0400 [thread overview]
Message-ID: <200904060704.42087.vapier@gentoo.org> (raw)
In-Reply-To: <73173D32E9439E4ABB5151606C3E19E250840319@SC-VEXCH1.marvell.com>
On Monday 06 April 2009 06:46:29 Prafulla Wadaskar wrote:
> I missed subject info (i.e. PATCH v2) is this a problem? Shall I send it
> again?
dont worry about it. the [PATCH ...] contents of the summary are dropped when
merging into git. however, there is one other thing:
> > Subject: [PATCH] Macronix MX25xx MTD SPI flash driver
> >
> > From: prafulla_wadaskar <prafulla@marvell.com>
> >
> > Added macronix SF driver for MTD framework MX25L12805D is
> > supported and tested
> > TBD: sector erase implementation, other deivces support
> >
> > Change log:
> > v2: typos corrected, MX25PXX renamed as MX25XX, spi_flash
> > struct declared as first member, RDSR command limited to 8bit
> > transfer and cosmetic fixes
> >
> > Signed-off-by: prafulla_wadaskar <prafulla@marvell.com>
> > Reviewed by: Mike Frysinger <vapier@gentoo.org> Tested by:
> > prafulla_wadaskar <prafulla@marvell.com>
> >
> > Signed-off-by: prafulla_wadaskar <prafulla@marvell.com>
> > ---
> > drivers/mtd/spi/Makefile | 1 +
the patch change log should go under that "---" rather than above it. the
patch change log is to make reviewers' lives easier, not to go into the actual
commit message. but dont worry about sending another patch, i'll just fix it
up when i merge it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090406/802026ce/attachment.pgp
next prev parent reply other threads:[~2009-04-06 11:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 15:54 [U-Boot] [PATCH] Macronix MX25xx MTD SPI flash driver Prafulla Wadaskar
2009-04-06 10:46 ` Prafulla Wadaskar
2009-04-06 11:04 ` Mike Frysinger [this message]
2009-04-06 11:17 ` Prafulla Wadaskar
2009-04-06 11:11 ` Mike Frysinger
2009-04-06 18:15 ` Wolfgang Denk
2009-04-06 21:48 ` Mike Frysinger
2009-04-06 11:17 ` Mike Frysinger
2009-04-06 18:13 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2009-04-03 11:49 [U-Boot] [PATCH] debug_print macros support Prafulla Wadaskar
2009-04-03 11:49 ` [U-Boot] [PATCH] bin_dep.sh Support Prafulla Wadaskar
2009-04-03 11:49 ` [U-Boot] [PATCH] Macronix MX25xx MTD SPI flash driver Prafulla Wadaskar
2009-04-03 14:14 ` Mike Frysinger
2009-04-06 7:23 ` Prafulla Wadaskar
2009-04-06 7:39 ` Mike Frysinger
2009-04-06 8:27 ` Prafulla Wadaskar
2009-04-06 8:49 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904060704.42087.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox