From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Question about M29W128G CFI QRY bug
Date: Wed, 15 Apr 2009 17:26:19 +0200 [thread overview]
Message-ID: <200904151726.19326.sr@denx.de> (raw)
In-Reply-To: <200904151630.02072.sr@denx.de>
On Wednesday 15 April 2009, Stefan Roese wrote:
> > > I don't like both versions. We should implement something which doesn't
> > > change the current behavior probably needed on some other boards. So
> > > how about something like this:
> >
> > I took your proposal and tried to implement it, hit a snag with
> > flash_write_cmd currently being a private function of cfi-flash.c
> > so, here is my 'counter-offer' pasted at the end of the message.
>
> Thanks. Looks good. I'll take it and prepare a proper patch.
Hmm. After looking a bit closer this doesn't seem to be this easy. I would
like to add this function prototype to include/flash.h where other defines
and function prototypes are collected right now. But this breaks some other
boards implementing "their own" flash driver in their board directories, like
AP1000, cpci5200, G2000, ppmc8260 and sbc405 (maintainers added to CC).
All those boards should be able to use the common CFI flash driver. I would
really like to see those boards converted to this driver. It should be pretty
easy. So maintainers from the boards mentioned above, if you need any help
with this just let me know.
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2009-04-15 15:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 23:29 [U-Boot] Question about M29W128G CFI QRY bug Richard Retanubun
2009-04-13 15:35 ` Richard Retanubun
2009-04-14 9:43 ` Stefan Roese
2009-04-14 22:50 ` Richard Retanubun
2009-04-15 8:22 ` Stefan Roese
2009-04-15 13:34 ` Richard Retanubun
2009-04-15 14:30 ` Stefan Roese
2009-04-15 15:26 ` Stefan Roese [this message]
2009-05-01 21:29 ` Richard Retanubun
2009-10-27 14:27 ` Stefan Roese
2009-10-27 17:39 ` Richard Retanubun
2009-10-27 19:02 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904151726.19326.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox