From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ppc4xx: Remove unused code for Sequoia NAND booting version
Date: Thu, 16 Apr 2009 11:16:05 +0200 [thread overview]
Message-ID: <200904161116.05407.sr@denx.de> (raw)
In-Reply-To: <20090416085952.E56F383420E8@gemini.denx.de>
Hi Wolfgang,
On Thursday 16 April 2009, Wolfgang Denk wrote:
> Overwriting the function definition in "cpu/ppc4xx/speed.c" with a
> #define like here is pretty ugly.
>
> Looking closer at this, I think the whole implementation of
> get_bus_freq() needs to be cleaned up. Why does get_bus_freq() need
> an agument? I don't see it used anywhere - not on 4xx nor on any
> other architecture.
Agreed. But this is a bigger task. Perhaps their is some volunteer somewhere
doing such a cleanup.
But back to my little patch. What exactly do you want me to do now? With my
patch the situation changes definitely to the better (from my point of view).
But I can easily drop this patch from my patch series if you really don't
want this change.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2009-04-16 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 7:13 [U-Boot] [PATCH v2] ppc4xx: Remove unused code for Sequoia NAND booting version Stefan Roese
2009-04-16 8:59 ` Wolfgang Denk
2009-04-16 9:16 ` Stefan Roese [this message]
2009-04-16 9:19 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904161116.05407.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox