From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/7] i2c: Create common default i2c_[set|get]_bus_speed() functions
Date: Mon, 20 Apr 2009 00:54:56 -0400 [thread overview]
Message-ID: <200904200054.57277.vapier@gentoo.org> (raw)
In-Reply-To: <1240110838.15397.13.camel@ptyser-laptop>
On Saturday 18 April 2009 23:13:58 Peter Tyser wrote:
> On Sat, 2009-04-18 at 14:23 -0400, Mike Frysinger wrote:
> > On Thursday 16 April 2009 15:41:22 Peter Tyser wrote:
> > > +unsigned int i2c_get_bus_speed(void)
> > > + __attribute((weak, alias("__def_i2c_get_bus_speed")));
> >
> > __attribute__ ?
>
> Interesting, thanks for catching that. I blindly copied the weak
> functions in net/eth.c which also use the __attribute declaration. It
> looks like gcc treats __attribute and __attribute__ the same, but I
> couldn't find any definitive info on __attribute. I'll resubmit using
> __attribute__.
>
> Anyone have a reason that we shouldn't replace all u-boot references to
> __attribute with __attribute__?
not that i know of ... using __XXX__ with gcc keywords tends to be preferred.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090420/d2094f4f/attachment.pgp
next prev parent reply other threads:[~2009-04-20 4:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 19:41 [U-Boot] [PATCH 0/7] Remove individual I2C commands and cleanup Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 1/7] cm5200: Make function test command names more unique Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 2/7] i2c: Create common default i2c_[set|get]_bus_speed() functions Peter Tyser
2009-04-18 18:23 ` Mike Frysinger
2009-04-19 3:13 ` Peter Tyser
2009-04-20 4:54 ` Mike Frysinger [this message]
2009-04-16 19:41 ` [U-Boot] [PATCH 3/7] i2c: Remove deprecated individual i2c commands Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 4/7] i2c: Update references to " Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 5/7] cmd_i2c: Clean up i2c command argument parsing Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 6/7] cmd_i2c: Clean up trivial helper functions Peter Tyser
2009-04-16 19:41 ` [U-Boot] [PATCH 7/7] cmd_i2c: Fix i2c help command output when CONFIG_I2C_MUX Peter Tyser
2009-04-16 22:08 ` [U-Boot] [PATCH 0/7] Remove individual I2C commands and cleanup Timur Tabi
2009-04-17 6:20 ` Heiko Schocher
2009-04-17 13:32 ` Jerry Van Baren
2009-04-18 7:11 ` Heiko Schocher
2009-04-17 16:43 ` Peter Tyser
2009-04-18 7:14 ` Heiko Schocher
2009-04-23 6:18 ` [U-Boot] [PATCH v2 " Heiko Schocher
2009-04-23 7:02 ` Heiko Schocher
2009-04-23 23:06 ` Peter Tyser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904200054.57277.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox