public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] OMAP3: Remove unused board-types
Date: Fri, 24 Apr 2009 22:03:23 +0200	[thread overview]
Message-ID: <20090424200323.GD2953@game.jcrosoft.org> (raw)
In-Reply-To: <20090424193423.1A2A583420E8@gemini.denx.de>

On 21:34 Fri 24 Apr     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20090424164422.GB2953@game.jcrosoft.org> you wrote:
> > On 20:21 Fri 24 Apr     , Sanjeev Premi wrote:
> > > The board-types defined in struct omap3_sysinfo seem to be
> > > unused. The function display_board_info() is passed
> > > board type as an argument; which is ignored.
> > > 
> > > This patch removes all uses of board-type, related definitions
> > > and functions.
> > I've forget to tell you this on the precedent patch but we have
> >  print_cpuinfo for printing cpu/soc info and checkboard for board info
> > 
> > could you move the STD API 
> 
> What exactly do you mean by "move the STD API"? 
> 
> In which way should the "STD API" be moved, and what exactly is the
> "STD API" you are referring to?

extract of arm init function

#if defined(CONFIG_DISPLAY_CPUINFO)
	print_cpuinfo,		/* display cpu info (and speed) */
#endif
#if defined(CONFIG_DISPLAY_BOARDINFO)
	checkboard,		/* display board info */
#endif

I want we use the current API and not re-invent a new API for an arch only

so Sanjeev please use it

> 
> 
> And please, could you *please* be clear about what your comments mean
> - I have no idea if your comment above  means  that  you  reject  the
> patch,  or  if  you  request  it to be changed (in which case I don;t
> understand how it should be changed, or why), or if you are going  to
> apply it.
Change requested

Best Regards,
J.

  reply	other threads:[~2009-04-24 20:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24 14:51 [U-Boot] [PATCH 1/2] OMAP3: Remove unused board-types Sanjeev Premi
2009-04-24 16:44 ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-24 16:59   ` Dirk Behme
2009-04-24 20:04     ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-24 19:34   ` Wolfgang Denk
2009-04-24 20:03     ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-04-24 21:01       ` Wolfgang Denk
2009-04-25 12:50         ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-26  4:56           ` Dirk Behme
2009-04-26 18:58             ` Wolfgang Denk
2009-04-24 16:47 ` Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090424200323.GD2953@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox