From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 27 Apr 2009 09:27:28 +0200
Subject: [U-Boot] [PATCH 1/2] LPC2468 support
In-Reply-To: <20090425124755.GC25381@game.jcrosoft.org>
References: <49C8BE7A.10504@duran-audio.com>
	<20090424221408.8074D83420E8@gemini.denx.de>
	<20090425124755.GC25381@game.jcrosoft.org>
Message-ID: <200904270927.29232.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Saturday 25 April 2009, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > In message <20090424215804.GC10032@game.jcrosoft.org> you wrote:
> >
> > ...
> >
> > > > +#define COPY_BUFFER_LOCATION 0x4000fde0
> > >
> > > evenif it's soc specific flash support I think they need to be store
> > > with the other flash and need to have the ack of Stefan
> >
> > No, not really. Stefan cares only about the CFI driver, and this is
> > clearly not a CFI conformant flash type.
>
> ok but I steel wish to have Stefan opinion

I took a quick look at the flash "driver". The main functions  
lpc24xx_flash_erase() and lpc24xx_write_buff() are not even referenced 
somewhere in this patch. They seem to be used in the 2nd patch (2/2) though. 
It's hard to really understand what's going on here. So this flash driver 
part really needs some sort of documentation how it's supposed to work.

And I also think this driver (as all FLASH related drivers) should be moved 
into drivers/mtd instead.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================