From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 28 Apr 2009 09:08:01 +0200 Subject: [U-Boot] [PATCH 1/2] LPC2468 support In-Reply-To: <20090428064626.E7C6D83420E8@gemini.denx.de> References: <49C8BE7A.10504@duran-audio.com> <200904280827.45894.sr@denx.de> <20090428064626.E7C6D83420E8@gemini.denx.de> Message-ID: <200904280908.02114.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, On Tuesday 28 April 2009, Wolfgang Denk wrote: > > > Into drivers/mtd? Even if it's not a MTD driver? This doesn't make > > > mnuch sense to me. > > > > In the end this driver will be used by the common FLASH user interface > > (cmd_flash.c, cmd_mem.c). So I prefer to have the "driver" for this > > interface > > Yes. But MTD is a description of a specific interface. Even now we > have two versions of the CFI driver: drivers/mtd/cfi_flash.c and > drivers/mtd/cfi_mtd.c, No, we don't have "two versions of the CFI driver". cfi_mtd.c is not really a driver but "only" a wrapper implementing the MTD infrastructure on top of the U-Boot NOR driver (cfi_flash or others). > and if we look closer at it only cfi_mtd.c > makes sense in this directory. cfi_flash.c is *not* MTD conformant > and should be somewhere else. > > > in a common place for a better overview. And the only common place I can > > think of is drivers/mtd right now. We should probably add a subdirectory > > for > > Maybe we should create drivers/flash for those non-MTD flash drivers? > Then we should also move cfi_flash.c there. Yes, this could be done. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================