public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] U-Boot Timer Qualification
Date: Wed, 29 Apr 2009 21:26:36 +0200	[thread overview]
Message-ID: <20090429192636.GD13941@game.jcrosoft.org> (raw)
In-Reply-To: <20090428174726.C06BB83420E8@gemini.denx.de>

On 19:47 Tue 28 Apr     , Wolfgang Denk wrote:
> Dear Ladislav Michl,
> 
> In message <20090428151147.GA19683@linux-mips.org> you wrote:
> > 
> > a lot of changes are entering arm tree, many without any commit message.
> > And now we have some special cases which needs some special care for yet
> > unclear reason. OMAP3 timer precission was discussed to death and patch
> > still didn't went in, because it needs to be verified against some
> > document you are claiming is not mandatory.
> 
> Just in case there is any doubt here:
> 
> There is no, and I say *no*, mandatory verification of any timing
> precision in U-Boot.
> 
> We all agree that precision is a good thing to have, it it must come
> at a reasonable effort, and there is no reason to drive it into
> extreme precision.
Personnaly I never ask extreme precision
I ask to known the precision

as the timer is incorrect to known where we go is important

> 
> Clock signals may need an accuracy of 1 or 2% or better - as we may
> see character corruption if the baudrate generators are off too far -
> but this is usually a hardware issue in the first place.
> 
> System timers (like udelay() etc.) in U-Boot do not need such a level
> of accuracy. That does not mean we should intentionally be inaccurate.
> 
> And of course actual testing is good, and documentation of the test
> results is even better.
> 
> But: it is not mandatory. Not in U-Boot (and also not in Linux, to the
> best of my knowledge).
As example when the timer was send by a dev at first and he will send a fix
I think it's start to be mandatory to ask him to test it an a the real hard
It will avoid to have a new fix again and again
which will mean that the timer is never been check in a real use case

> 
> See my previuous posting. I don;t think that a generic test method
> that works on all boards would be possible.
but a docmument and code to do is good and will hepl the dev evenif we can
known and support all boards. This will be improve with patch.

Best Regards,
J.

  parent reply	other threads:[~2009-04-29 19:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22 20:49 [U-Boot] U-Boot Timer Qualification Jean-Christophe PLAGNIOL-VILLARD
2009-04-22 21:08 ` Wolfgang Denk
2009-04-22 21:28   ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-22 22:18     ` Wolfgang Denk
2009-04-23  8:01       ` Ladislav Michl
2009-04-23 14:52         ` [U-Boot] IRC log?, was: " Dirk Behme
2009-04-27 19:28         ` [U-Boot] " Mike Frysinger
2009-04-28 10:08           ` Ladislav Michl
2009-04-28 12:48             ` Mike Frysinger
2009-04-28 13:41               ` Wolfgang Denk
2009-04-28 15:53                 ` Mike Frysinger
2009-04-28 15:11               ` Ladislav Michl
2009-04-28 17:47                 ` Wolfgang Denk
2009-04-29 16:48                   ` Dirk Behme
2009-04-29 18:00                     ` Wolfgang Denk
2009-04-29 19:26                   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-04-29 22:21                     ` Wolfgang Denk
2009-04-27 19:42 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090429192636.GD13941@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox