public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3][Net][ARM] Switched dm644x_emac Ethernet	driver to use newer API
Date: Wed, 29 Apr 2009 22:13:35 +0200	[thread overview]
Message-ID: <20090429201335.GB522@game.jcrosoft.org> (raw)
In-Reply-To: <1240938733-3121-4-git-send-email-biggerbadderben@gmail.com>

On 10:12 Tue 28 Apr     , Ben Warren wrote:
>  Added CONFIG_NET_MULTI to all Davinci boards
>  Removed all calls to Davinci network driver from board code
>  Added cpu_eth_init() to cpu/arm926ejs/cpu.c
> 
> Signed-off-by: Ben Warren <biggerbadderben@gmail.com>
> ---
>  board/davinci/common/misc.h         |    1 -
>  board/davinci/dvevm/dvevm.c         |    3 -
>  board/davinci/schmoogie/schmoogie.c |    3 -
>  board/davinci/sffsdr/sffsdr.c       |    3 -
>  board/davinci/sonata/sonata.c       |    3 -
>  cpu/arm926ejs/cpu.c                 |   13 ++++++
>  drivers/net/dm644x_emac.c           |   70 ++++++++++++-----------------------
>  include/configs/davinci_dvevm.h     |    1 +
>  include/configs/davinci_schmoogie.h |    1 +
>  include/configs/davinci_sffsdr.h    |    1 +
>  include/configs/davinci_sonata.h    |    1 +
>  include/netdev.h                    |    1 +
>  net/eth.c                           |    4 --
>  13 files changed, 42 insertions(+), 63 deletions(-)
> 
> diff --git a/board/davinci/common/misc.h b/board/davinci/common/misc.h
> index 4a57dbb..25b19b8 100644
> --- a/board/davinci/common/misc.h
> +++ b/board/davinci/common/misc.h
> @@ -23,7 +23,6 @@
>  #define __MISC_H
>  
>  extern void timer_init(void);
> -extern int eth_hw_init(void);
>  
>  void dv_display_clk_infos(void);
>  int dvevm_read_mac_address(uint8_t *buf);
> diff --git a/board/davinci/dvevm/dvevm.c b/board/davinci/dvevm/dvevm.c
> index 22308de..9fdfa58 100644
> --- a/board/davinci/dvevm/dvevm.c
> +++ b/board/davinci/dvevm/dvevm.c
> @@ -76,9 +76,6 @@ int misc_init_r(void)
>  	if (dvevm_read_mac_address(eeprom_enetaddr))
>  		dv_configure_mac_address(eeprom_enetaddr);
>  
> -	if (!eth_hw_init())
> -		printf("ethernet init failed!\n");
> -
>  	i2c_read(0x39, 0x00, 1, &video_mode, 1);
>  
>  	setenv("videostd", ((video_mode & 0x80) ? "pal" : "ntsc"));
> diff --git a/board/davinci/schmoogie/schmoogie.c b/board/davinci/schmoogie/schmoogie.c
> index 433769a..738e9dd 100644
> --- a/board/davinci/schmoogie/schmoogie.c
> +++ b/board/davinci/schmoogie/schmoogie.c
> @@ -133,8 +133,5 @@ int misc_init_r(void)
>  		forceenv("serial#", (char *)&tmp[0]);
>  	}
>  
> -	if (!eth_hw_init())
> -		printf("ethernet init failed!\n");
> -
>  	return(0);
>  }
> diff --git a/board/davinci/sffsdr/sffsdr.c b/board/davinci/sffsdr/sffsdr.c
> index e76f86d..45d0456 100644
> --- a/board/davinci/sffsdr/sffsdr.c
> +++ b/board/davinci/sffsdr/sffsdr.c
> @@ -146,8 +146,5 @@ int misc_init_r(void)
>  	if (sffsdr_read_mac_address(eeprom_enetaddr))
>  		dv_configure_mac_address(eeprom_enetaddr);
>  
> -	if (!eth_hw_init())
> -		printf("Ethernet init failed\n");
> -
>  	return(0);
>  }
> diff --git a/board/davinci/sonata/sonata.c b/board/davinci/sonata/sonata.c
> index d56b443..73bd25f 100644
> --- a/board/davinci/sonata/sonata.c
> +++ b/board/davinci/sonata/sonata.c
> @@ -73,8 +73,5 @@ int misc_init_r(void)
>  	if (dvevm_read_mac_address(eeprom_enetaddr))
>  		dv_configure_mac_address(eeprom_enetaddr);
>  
> -	if (!eth_hw_init())
> -		printf("ethernet init failed!\n");
> -
>  	return(0);
>  }
> diff --git a/cpu/arm926ejs/cpu.c b/cpu/arm926ejs/cpu.c
> index 6307e33..d711b24 100644
> --- a/cpu/arm926ejs/cpu.c
> +++ b/cpu/arm926ejs/cpu.c
> @@ -31,6 +31,7 @@
>  
>  #include <common.h>
>  #include <command.h>
> +#include <netdev.h>
>  #include <arm926ejs.h>
>  #include <asm/system.h>
>  
> @@ -80,3 +81,15 @@ static void cache_flush (void)
>  
>  	asm ("mcr p15, 0, %0, c7, c7, 0": :"r" (i));
>  }
> +
> +/*
> + *  * Initializes on-chip ethernet controllers.
> + *   * to override, implement board_eth_init()
> + *    */
> +int cpu_eth_init(bd_t *bis)
> +{
> +#if defined(CONFIG_DRIVER_TI_EMAC)
> +	dm644x_emac_initialize();
> +#endif
> +	return 0;
> +}
please move this to the soc
arm926ejs/davinci/cpu.c

the cpu.c is destinated to be removed in most of the case
or at least all the soc specific code

Best Regards,
J.

  reply	other threads:[~2009-04-29 20:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 17:12 [U-Boot] [PATCH 0/3][Net][ARM] Davinci Ethernet driver cleanup Ben Warren
2009-04-28 17:12 ` [U-Boot] [PATCH 1/3][Net][ARM] Moved Davinci Ethernet driver to drivers/net Ben Warren
2009-04-28 17:12   ` [U-Boot] [PATCH 2/3][Net][ARM] Initial cleanup of Davinci Ethernet driver Ben Warren
2009-04-28 17:12     ` [U-Boot] [PATCH 3/3][Net][ARM] Switched dm644x_emac Ethernet driver to use newer API Ben Warren
2009-04-29 20:13       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-04-29 20:29         ` Ben Warren
2009-04-29 20:49           ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-29 22:11             ` Ben Warren
2009-04-29 23:19               ` Jean-Christophe PLAGNIOL-VILLARD
2009-04-30  4:28                 ` David Brownell
2009-04-28 19:54   ` [U-Boot] [PATCH 1/3][Net][ARM] Moved Davinci Ethernet driver to drivers/net David Brownell
2009-04-28 20:04     ` Ben Warren
2009-04-29 23:32 ` [U-Boot] [PATCH 0/3][Net][ARM] Davinci Ethernet driver cleanup David Brownell
2009-04-29 23:38   ` Ben Warren
2009-04-30  5:59 ` Jean-Christophe PLAGNIOL-VILLARD
     [not found] ` <C9D59C82B94F474B872F2092A87F26148147B6A3@dlee07.ent.ti.com>
2009-05-12 17:43   ` Ben Warren
2009-05-12 18:28     ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090429201335.GB522@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox