[U-Boot] [PATCH 4/6] fsl_esdhc: Add device tree fixups

[Anton Vorontsov <avorontsov@ru.mvista.com>]

Hi Andy,

Sorry for the late response,

On Fri, Mar 06, 2009 at 07:25:55PM -0600, Andy Fleming wrote:
> On Thu, Feb 19, 2009 at 9:45 AM, Anton Vorontsov
> <avorontsov@ru.mvista.com> wrote:
> > This patch implements fdt_fixup_esdhc() function that is used to fixup
> > the device tree.
> >
> > The function adds status = "disabled" propery if esdhc pins muxed away,
> > otherwise it fixups clock-frequency for esdhc nodes.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> > ---
> > ?drivers/mmc/fsl_esdhc.c | ? 22 ++++++++++++++++++++++
> > ?include/fsl_esdhc.h ? ? | ? ?8 ++++++++
> > ?2 files changed, 30 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> > index 0ba45cd..fe8bd86 100644
> > --- a/drivers/mmc/fsl_esdhc.c
> > +++ b/drivers/mmc/fsl_esdhc.c
> > @@ -33,6 +33,8 @@
> > ?#include <malloc.h>
> > ?#include <mmc.h>
> > ?#include <fsl_esdhc.h>
> > +#include <fsl_can_use.h>
> > +#include <fdt_support.h>
> > ?#include <asm/io.h>
> >
> >
> > @@ -346,3 +348,23 @@ int fsl_esdhc_mmc_init(bd_t *bis)
> > ?{
> > ? ? ? ?return esdhc_initialize(bis);
> > ?}
> > +
> > +#ifdef CONFIG_MPC85xx
> > +#define ESDHC_COMPATIBLE "fsl,mpc8536-esdhc"
> > +#else
> > +#define ESDHC_COMPATIBLE "fsl,mpc8379-esdhc"
> > +#endif
> 
> Isn't there a more global means of doing this?  I don't like having
> the 8536/8379 in the driver, itself.

But that's how we prefer bindings nowadays.

> Actually, there is.  Move these
> to the config file.  But there should be a compatible property that
> works for all esdhc devices.

Starting from MPC83xx/MPC85xx GPIO controllers, we try to
differentiate 85xx and 83xx parts. I.e. 85xx family doesn't
specify 83xx family's compatible entries, even if the controllers
are compatible. I'm just following the trend.

So the current scheme is:
"fsl,device-<chip>", "fsl,device-<first-chip-in-a-family>;

See this discussion:

http://ozlabs.org/pipermail/linuxppc-dev/2008-September/062934.html

And some quotes from accepted bindings:

 Documentation/powerpc/dts-bindings/fsl/8xxx_gpio.txt:
  - compatible : "fsl,<CHIP>-gpio" followed by "fsl,mpc8349-gpio" for
    83xx, "fsl,mpc8572-gpio" for 85xx and "fsl,mpc8610-gpio" for 86xx.

 Documentation/powerpc/dts-bindings/fsl/esdhc.txt:
  - compatible : should be
    "fsl,<chip>-esdhc", "fsl,mpc8379-esdhc" for MPC83xx processors.
    "fsl,<chip>-esdhc", "fsl,mpc8536-esdhc" for MPC85xx processors.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru at gmail.com
irc://irc.freenode.net/bd2