U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v9] Marvell MV88E61XX Switch Driver support
Date: Tue, 5 May 2009 00:12:57 +0200	[thread overview]
Message-ID: <20090504221257.GC13923@game.jcrosoft.org> (raw)
In-Reply-To: <1241448927-25881-1-git-send-email-prafulla@marvell.com>

> --- a/include/netdev.h
> +++ b/include/netdev.h
> @@ -28,6 +28,34 @@
>  #ifndef _NETDEV_H_
>  #define _NETDEV_H_
>  
> +/* constants for switch configuration */
> +enum switch_cfg_vlan {
IHMO in this case it must be mvxxxx_swtich .....

and maybe cover by a defive

but I not sure it's the rigth place for this

> +	SWITCH_VLANCFG_DEFAULT,
> +	SWITCH_VLANCFG_ROUTER
> +};
> +
> +enum switch_cfg_rgmiid {
> +	SWITCH_RGMII_DELAY_DIS,
> +	SWITCH_RGMII_DELAY_EN
> +};
> +
> +enum switch_cfg_prtstt {
> +	SWITCH_PORTSTT_DISABLED,
> +	SWITCH_PORTSTT_BLOCKING,
> +	SWITCH_PORTSTT_LEARNING,
> +	SWITCH_PORTSTT_FORWARDING
> +};
> +
> +/* switch configuration structure */
> +struct switch_config {
> +	char *name;
> +	enum switch_cfg_vlan vlancfg;
> +	enum switch_cfg_rgmiid rgmii_delay;
> +	enum switch_cfg_prtstt portstate;
> +	u32 ports_enabled;
> +	u8 cpuport;
> +};
a simple
struct switch_config;

and the a MV88E61XX_H

will be cleaner

Best Regards,
J.

  reply	other threads:[~2009-05-04 22:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04 14:55 [U-Boot] [PATCH v9] Marvell MV88E61XX Switch Driver support Prafulla Wadaskar
2009-05-04 22:12 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-05-05  3:09   ` Prafulla Wadaskar
2009-05-04 22:41 ` Ben Warren
2009-05-05  3:10   ` Prafulla Wadaskar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090504221257.GC13923@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox