From: Daniel Mack <daniel@caiaq.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: unbreak PXA build by defining UP2OCR
Date: Tue, 5 May 2009 12:16:06 +0200 [thread overview]
Message-ID: <20090505101606.GD22117@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090504225857.C088A83420E8@gemini.denx.de>
On Tue, May 05, 2009 at 12:58:57AM +0200, Wolfgang Denk wrote:
> > the usb driver use the same file for supporting all the PXA
> > and as it's store in a generic header. We must define the register only
> > the specific pxa version and when the same register could mean differents
> > things depending the pxa version
>
> That's the theory. Praxis is that we have a bug, and we need a fix.
> And we seem to have one.
Correct. It does not build anymore. Another possibility is to revert the
commit which caused the trouble and make Markus Klotzbuecher fix it in a
way Jean-Christophe PLAGNIOL-VILLARD likes.
> - how many PXA platforms with USB support do we have?
That's not the point. I for myself won't bring my board support into
U-Boot's mainline (at least not now) because that would help nobody as
nobody except for me has the hardware the code was written for. And I
guess I'm not the only one.
IMO hings should compile, even when the config for this is not in your
repository; hope you agree.
> In other words - is your concern a real problem, or just a theoretical
> one?
Code using that macro is guarded by MONAHANS #ifdefs anyway, his point
is solely not to have it in the register headers.
Daniel
next prev parent reply other threads:[~2009-05-05 10:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 10:34 [U-Boot] [PATCH] ARM: unbreak PXA build by defining UP2OCR Daniel Mack
2009-05-04 11:22 ` Markus Klotzbücher
2009-05-04 12:05 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-04 18:40 ` Wolfgang Denk
2009-05-04 22:41 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-04 22:58 ` Wolfgang Denk
2009-05-04 23:16 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-05 10:16 ` Daniel Mack [this message]
2009-05-05 10:28 ` Wolfgang Denk
2009-05-05 10:36 ` Daniel Mack
2009-05-05 10:48 ` Daniel Mack
2009-05-07 20:36 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-07 21:00 ` Wolfgang Denk
2009-05-07 21:02 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-07 22:50 ` Daniel Mack
2009-05-05 11:19 ` Wolfgang Denk
2009-05-05 11:14 ` Markus Klotzbücher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090505101606.GD22117@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox