From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Mack <daniel@caiaq.de>
Date: Tue, 5 May 2009 12:16:06 +0200
Subject: [U-Boot] [PATCH] ARM: unbreak PXA build by defining UP2OCR
In-Reply-To: <20090504225857.C088A83420E8@gemini.denx.de>
References: <1241433241-29785-1-git-send-email-daniel@caiaq.de>
	<20090504120514.GD25959@game.jcrosoft.org>
	<20090504184026.EC5EB83420E8@gemini.denx.de>
	<20090504224128.GF13923@game.jcrosoft.org>
	<20090504225857.C088A83420E8@gemini.denx.de>
Message-ID: <20090505101606.GD22117@buzzloop.caiaq.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, May 05, 2009 at 12:58:57AM +0200, Wolfgang Denk wrote:
> > the usb driver use the same file for supporting all the PXA
> > and as it's store in a generic header. We must define the register only
> > the specific pxa version and when the same register could mean differents
> > things depending the pxa version
> 
> That's the theory.  Praxis is that we have a bug, and we need a fix.
> And we seem to have one.

Correct. It does not build anymore. Another possibility is to revert the
commit which caused the trouble and make Markus Klotzbuecher fix it in a
way Jean-Christophe PLAGNIOL-VILLARD likes.

> - how many PXA platforms with USB support do we have?

That's not the point. I for myself won't bring my board support into
U-Boot's mainline (at least not now) because that would help nobody as
nobody except for me has the hardware the code was written for. And I
guess I'm not the only one.

IMO hings should compile, even when the config for this is not in your
repository; hope you agree.

> In other words - is your concern a real problem, or just a theoretical
> one?

Code using that macro is guarded by MONAHANS #ifdefs anyway, his point
is solely not to have it in the register headers.

Daniel