[U-Boot] [PATCH v2] mtd: nand: new base driver for memory mapped nand devices

[Mike Frysinger <vapier@gentoo.org>]

On Wednesday 06 May 2009 13:35:29 Scott Wood wrote:
> On Wed, May 06, 2009 at 09:05:21AM -0400, Mike Frysinger wrote:
> > + *  NAND_PLAT_WRITE_CMD(cmd, chip)
> > + *  NAND_PLAT_WRITE_ADR(cmd, chip)
>
> It seems counterintuitive to have "cmd" before "this" -- it's backwards
> from both cmd_ctrl and the blackfin command that you turn it into (yes,
> it's like writeb() -- but I always found that to be weird too).

np

> > +/* #define CONFIG_NAND_PLAT */
>
> Why is this commented out?

because it's a driver for an optional add-on card that people usually dont 
have, let alone plugged in

> > +#define NAND_PLAT_DEV_READY(chip)      ((*pPORTFIO & BFIN_NAND_READY) ?
> > 1 : 0)
>
> Why not just (*pPORTFIO & BFIN_NAND_READY)?

i thought the nand/mtd layers expect 1/0 only ?  if the higher layers dont 
care, then there's no reason.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090506/5352b9e1/attachment.pgp