From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] at91: Add command to control up to 3 GPIO LEDs from the console
Date: Wed, 6 May 2009 16:40:01 -0400 [thread overview]
Message-ID: <200905061640.02167.vapier@gentoo.org> (raw)
In-Reply-To: <20090506203728.9779B83420E8@gemini.denx.de>
On Wednesday 06 May 2009 16:37:28 Wolfgang Denk wrote:
> In message Daniel Gorsulowski wrote:
> > --- a/common/Makefile
> > +++ b/common/Makefile
> > +COBJS-$(CONFIG_CMD_LED) += cmd_led.o
>
> Ummm... common is for, well, for >>common<< stuff. If this code is
> specific to AT91 only, it should not go into common.
well, how common is common ? ive put commands in there that are common to all
Blackfin parts, but that's it ... should i be relocating them to lib_blackfin/
or something ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090506/08bf0730/attachment.pgp
next prev parent reply other threads:[~2009-05-06 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 14:21 [U-Boot] [PATCH 1/1] at91: Add command to control up to 3 GPIO LEDs from the console Daniel Gorsulowski
2009-05-06 20:37 ` Wolfgang Denk
2009-05-06 20:40 ` Mike Frysinger [this message]
2009-05-07 6:01 ` Daniel Gorsulowski
2009-05-07 7:32 ` Wolfgang Denk
2009-05-08 5:37 ` Daniel Gorsulowski
2009-05-07 6:31 ` Stefan Roese
2009-05-08 5:28 ` Daniel Gorsulowski
2009-05-08 6:21 ` Stefan Roese
2009-05-14 8:49 ` Daniel Gorsulowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905061640.02167.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox