U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yauhen Kharuzhy <jekhor@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: Remove return from mmc_init for non SD	2.0 compatible cards.
Date: Fri, 8 May 2009 00:52:48 +0300	[thread overview]
Message-ID: <20090507215248.GA26149@jeknote.loshitsa1.net> (raw)
In-Reply-To: <2acbd3e40905071313o4b6fbf98p68ac5c8bdf28e7de@mail.gmail.com>

On Thu, May 07, 2009 at 03:13:40PM -0500, Andy Fleming wrote:
> On Thu, May 7, 2009 at 5:08 AM, Yauhen Kharuzhy <jekhor@gmail.com> wrote:
> > Cards which are not compatible with SD 2.0 standard, cat return response
> > for CMD8 command, but it will be invalid in terms of SD 2.0. We should
> > accept this case as admissible.
> >
> > Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
> 
> 
> You've got a typo in the description on a key word, "cat".  Is it can't?  can?
I am sorry, yes, it is 'can'.
> 
> I'm not convinced that this patch is valid.  My understanding is that
> if a card receives a command it does not understand, it should not
> respond.  Thus, if it responds with an error, it's an actual error.
> Are you saying that some cards respond to cmd 8 that don't implement
> 2.0?  Because that would not totally surprise me, but would violate
> not just 2.0, but 1.x, as CMD8 is reserved.  MMC cards should also not
> respond to CMD8 at this stage in initialization, as they are in the
> wrong state...
I just to try all my cards with my device, and every card responds to
CMD8. Probably, this is bug in the implementation of the my MMC host driver
(for Ingenic JZ4740 SoC). I compared card initialization procedure with
Linux kernel's one and found that any error is ignored in it and means
that the card is not SD 2.0 compatible.

I will re-check the host controller driver for timeout handling, but it
seems clear.

-- 
Yauhen Kharuzhy		jekhor _at_ gmail.com
			JID: jek at jabber.ru

A: No
Q: Should I quote below my post?

  reply	other threads:[~2009-05-07 21:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-07 10:08 [U-Boot] [PATCH] mmc: Remove return from mmc_init for non SD 2.0 compatible cards Yauhen Kharuzhy
2009-05-07 20:13 ` Andy Fleming
2009-05-07 21:52   ` Yauhen Kharuzhy [this message]
2009-06-02 22:20     ` Andy Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090507215248.GA26149@jeknote.loshitsa1.net \
    --to=jekhor@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox