From: Daniel Mack <daniel@caiaq.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: unbreak PXA build by defining UP2OCR
Date: Fri, 8 May 2009 00:50:14 +0200 [thread overview]
Message-ID: <20090507225014.GA14741@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090507210234.GB6454@game.jcrosoft.org>
On Thu, May 07, 2009 at 11:02:34PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Can you please run a "git show 24e37645" again?
> >
> > To me it seems that this commit
> >
> > - removed the usage of UP2OCR from board/delta/delta.c
> > but also
> > - added the usage of UP2OCR to the new file cpu/pxa/usb.c
> > without defining it.
> >
> >
> > So the comment seems absolutely correct to me. Maybe I'm missing
> > something?
> It's me I mix the commit
> this commit 3ccbfb25f48a:Support for PXA27X UDC.
> brake the pxa support
> by removing the UP2OCR
I was just running 'git blame' on the file that broke the build and
pointed out the commit that added the line that made the trouble. I
don't see what shouldn't be correct about that?
Anyway, feel free to change the commit log if you like, I don't
care. Most important thing is that things get fixed.
Thanks,
Daniel
next prev parent reply other threads:[~2009-05-07 22:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-04 10:34 [U-Boot] [PATCH] ARM: unbreak PXA build by defining UP2OCR Daniel Mack
2009-05-04 11:22 ` Markus Klotzbücher
2009-05-04 12:05 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-04 18:40 ` Wolfgang Denk
2009-05-04 22:41 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-04 22:58 ` Wolfgang Denk
2009-05-04 23:16 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-05 10:16 ` Daniel Mack
2009-05-05 10:28 ` Wolfgang Denk
2009-05-05 10:36 ` Daniel Mack
2009-05-05 10:48 ` Daniel Mack
2009-05-07 20:36 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-07 21:00 ` Wolfgang Denk
2009-05-07 21:02 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-07 22:50 ` Daniel Mack [this message]
2009-05-05 11:19 ` Wolfgang Denk
2009-05-05 11:14 ` Markus Klotzbücher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090507225014.GA14741@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox