From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Date: Fri, 8 May 2009 00:50:14 +0200 Subject: [U-Boot] [PATCH] ARM: unbreak PXA build by defining UP2OCR In-Reply-To: <20090507210234.GB6454@game.jcrosoft.org> References: <20090505103623.GE22117@buzzloop.caiaq.de> <1241520509-17457-1-git-send-email-daniel@caiaq.de> <20090507203647.GA3302@game.jcrosoft.org> <20090507210022.B5244832C2FB@gemini.denx.de> <20090507210234.GB6454@game.jcrosoft.org> Message-ID: <20090507225014.GA14741@buzzloop.caiaq.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, May 07, 2009 at 11:02:34PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > Can you please run a "git show 24e37645" again? > > > > To me it seems that this commit > > > > - removed the usage of UP2OCR from board/delta/delta.c > > but also > > - added the usage of UP2OCR to the new file cpu/pxa/usb.c > > without defining it. > > > > > > So the comment seems absolutely correct to me. Maybe I'm missing > > something? > It's me I mix the commit > this commit 3ccbfb25f48a:Support for PXA27X UDC. > brake the pxa support > by removing the UP2OCR I was just running 'git blame' on the file that broke the build and pointed out the commit that added the line that made the trouble. I don't see what shouldn't be correct about that? Anyway, feel free to change the commit log if you like, I don't care. Most important thing is that things get fixed. Thanks, Daniel