From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Sat, 9 May 2009 16:21:17 +0200 Subject: [U-Boot] [patch u-boot-git 2/2] davinci_nand: cleanup II (CONFIG_SYS_DAVINCI_BROKEN_ECC ) In-Reply-To: <200904281319.53898.david-b@pacbell.net> References: <200904281319.53898.david-b@pacbell.net> Message-ID: <20090509142117.GD13502@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 13:19 Tue 28 Apr , David Brownell wrote: > From: David Brownell > > Remove CONFIG_SYS_DAVINCI_BROKEN_ECC option. It's not just nasty; > it's also unused by any current boards, and doesn't even match the > main U-Boot distributions from TI (which use soft ECC, or 4-bit ECC > on newer chips that support it). > > DaVinci GIT kernels since 2.6.24, and mainline Linux since 2.6.30, > match non-BROKEN code paths for 1-bit HW ECC. The BROKEN code paths > do seem to partially match what MontaVista/TI kernels (4.0/2.6.10, > and 5.0/2.6.18) do ... but only for small pages. Large page support > is really broken (and it's unclear just what software it was trying > to match!), and the ECC layout was making three more bytes available > for use by filesystem (or whatever) code. > > Since this option itself seems broken, remove it. Add a comment > about the MV/TI compat issue, and the most straightforward way to > address it (should someone really need to solve it). > > Signed-off-by: David Brownell > --- Noone seems to worry about it maybe cc the linux davinci ML to announce that we remove it could be nice Scoot is it ok with you Otherwise Acked-by: Jean-Christophe PLAGNIOL-VILLARD Best Regards, J.