From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 3/3 V2] stdio/device: rework function naming convention
Date: Sun, 10 May 2009 16:17:02 +0200 [thread overview]
Message-ID: <20090510141702.GA21079@game.jcrosoft.org> (raw)
In-Reply-To: <20090509173229.8F816832E416@gemini.denx.de>
On 19:32 Sat 09 May , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <1241863009-26036-3-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > actually the console API use the following naming convention
>
> Please look up the difference in meaning between "actually" and "cur-
> rently"; I think you usually mean "currently" when you say "actually".
>
>
> This patch should preceed the previous one, where you already use the
> new, not yet introduced "stdio_" naming scheme.
>
> > ======Extract======
> > typedef struct device_t;
> >
> > int device_register (device_t * dev);
> > int devices_init (void);
> > int device_deregister(char *devname);
> > struct list_head* device_get_list(void);
> > device_t* device_get_by_name(char* name);
> > device_t* device_clone(device_t *dev);
> > =======
> >
> > which is not console dependent and is confusing
>
> I think this explanation is confusing, too, as I don't know whjat you
> mean by "console dependent".
device is a generic name
>
> > -#if defined(CONFIG_SPLASH_SCREEN) && !defined(CONFIG_SYS_DEVICE_NULLDEV)
> > -#define CONFIG_SYS_DEVICE_NULLDEV 1
> > +#if defined(CONFIG_SPLASH_SCREEN) && !defined(CONFIG_SYS_STDIO_NULLDEV)
> > +#define CONFIG_SYS_STDIO_NULLDEV 1
> > #endif
>
> I'm not happy about the CONFIG_SYS_STDIO_NULLDEV; the "NULL device" is
> actually a more general concept and not limited to the stdio handling.
> Please do not put a "STDIO" in this name.
here it's to active the stdio null device
Best Regards,
J.
next prev parent reply other threads:[~2009-05-10 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-09 9:56 [U-Boot] [PATCH 1/3] console.h: remove non implement function : console_realloc Jean-Christophe PLAGNIOL-VILLARD
2009-05-09 9:56 ` [U-Boot] [PATCH 2/3] console: unify printing current devices Jean-Christophe PLAGNIOL-VILLARD
2009-05-09 9:56 ` [U-Boot] [RFC PATCH 3/3 V2] stdio/device: rework function naming convention Jean-Christophe PLAGNIOL-VILLARD
2009-05-09 17:32 ` Wolfgang Denk
2009-05-09 18:23 ` Magnus Lilja
2009-05-10 14:17 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-05-10 19:37 ` Wolfgang Denk
2009-05-09 17:23 ` [U-Boot] [PATCH 2/3] console: unify printing current devices Wolfgang Denk
2009-05-09 17:15 ` [U-Boot] [PATCH 1/3] console.h: remove non implement function : console_realloc Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090510141702.GA21079@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox