From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Sun, 10 May 2009 16:44:04 +0200
Subject: [U-Boot] [PATCH 2/6] arm: remove cpu_init
In-Reply-To: <4A06856C.6050105@googlemail.com>
References: <1241876118-27469-1-git-send-email-plagnioj@jcrosoft.com>
	<1241876118-27469-2-git-send-email-plagnioj@jcrosoft.com>
	<4A06856C.6050105@googlemail.com>
Message-ID: <20090510144404.GD21079@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 09:42 Sun 10 May     , Dirk Behme wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>> move s3c44b0 to arch_cpu_init and as noone use cpu_init remove it
>>
>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
>
> Cortex-A8 (OMAP3) part
>
> Acked-by: Dirk Behme <dirk.behme@googlemail.com>
>
> Just a minor _question_ for an other board below:
>
>> diff --git a/cpu/s3c44b0/cpu.c b/cpu/s3c44b0/cpu.c
>> index 7ef4a1f..bca38f8 100644
>> --- a/cpu/s3c44b0/cpu.c
>> +++ b/cpu/s3c44b0/cpu.c
>> @@ -32,7 +32,7 @@
>>  #include <command.h>
>>  #include <asm/hardware.h>
>>  -int cpu_init (void)
>> +int arch_cpu_init (void)
>>  {
>>  	icache_enable();
>>  
>
> Would encapsulating this new arch_cpu_init() with an additional  
> CONFIG_ARCH_CPU_INIT, e.g.
no as this code is supposed to be always enable
>
> #if defined(CONFIG_ARCH_CPU_INIT)
> int arch_cpu_init (void)
> {
>
> (like below) help to avoid issues if cpu/s3c44b0/cpu.c would be compiled 
> without CONFIG_ARCH_CPU_INIT enabled?
why?
this is where the s3c44 enable the icache

Best Regards,
J.