From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Mon, 11 May 2009 09:17:21 +0200
Subject: [U-Boot] [PATCH 08/29] MPC512x: add support for ARIA board
In-Reply-To: <1241898668-11903-9-git-send-email-wd@denx.de>
References: <1241898668-11903-1-git-send-email-wd@denx.de>
	<1241898668-11903-9-git-send-email-wd@denx.de>
Message-ID: <200905110917.21667.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Saturday 09 May 2009 21:50:47 Wolfgang Denk wrote:
> ARIA is a MPC5121E based COM Express module by Dave/DENX.

Please find some comments below.

<snip>

> diff --git a/board/davedenx/aria/aria.c b/board/davedenx/aria/aria.c

<snip>

> +	/*
> +	 * Enable clocks
> +	 */
> +	out_be32(&im->clk.sccr[0], SCCR1_CLOCKS_EN);
> +	out_be32(&im->clk.sccr[1], SCCR2_CLOCKS_EN);
> +#if defined(CONFIG_IIM) || defined(CONFIG_CMD_FUSE)
> +	setbits_be32(&im->clk.sccr[1], CLOCK_SCCR2_IIM_EN);
> +#endif
> +
> +	return 0;
> +}
> +
> +phys_size_t initdram (int board_type)
> +{
> +	u32 msize = 0;
> +
> +	msize = fixed_sdram ();
> +
> +	return msize;
> +}

Or just:

phys_size_t initdram (int board_type)
{
	return fixed_sdram ();
}

And I noticed that are mixing the coding style's in this file (space before 
"(" of functions): fixed_sdram () vs. out_be(...). Better it would be 
consistent.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================