From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Mon, 11 May 2009 14:02:54 -0400
Subject: [U-Boot] [PATCH 3/4] net/dm9000: move the CONFIG_NET_MULTI api
In-Reply-To: <1242023969-13542-3-git-send-email-plagnioj@jcrosoft.com>
References: <1242023969-13542-1-git-send-email-plagnioj@jcrosoft.com>
	<1242023969-13542-2-git-send-email-plagnioj@jcrosoft.com>
	<1242023969-13542-3-git-send-email-plagnioj@jcrosoft.com>
Message-ID: <200905111402.56581.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday 11 May 2009 02:39:28 Jean-Christophe PLAGNIOL-VILLARD wrote:
> this add multi devices support and merge dm9000's eeprom command support

assuming this doesnt depend on the first two patches in this series, this 
sounds great to me

> +U_BOOT_CMD(
> +	dm9000ee,4,1,do_dm9000_eeprom,
> +	"Read/Write eeprom connected to Ethernet Controller",
> +	"\ndm9000ee write <name> <word offset> <value> \n"
> +	"\tdm9000ee read <name>\n"
> +	"\tword:\t\t00-02 : MAC Address\n"
> +	"\t\t\t03-07 : DM9000 Configuration\n"
> +	"\t\t\t08-63 : User data\n");

the usage is slightly damaged in the original ... be nice to not copy over 
that broken crap.  i.e. it should look like:
	"write <name> <word offset> <value>\n"
	"dm9000ee read <name>\n"
	"\tword:\t\t00-02 : MAC Address\n"
	"\t\t\t03-07 : DM9000 Configuration\n"
	"\t\t\t08-63 : User data\n");

> +int dm9000_eth_initialize(int id, u32 *data_addr, u32 *io_addr);

requiring the data and io addr to be 32bit aligned is not a real requirement 
is it ?  so perhaps it should be void* here instead of u32*.
-mike