public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: Update MTD infrastructure to support 64bit device size
Date: Mon, 11 May 2009 18:38:45 +0200	[thread overview]
Message-ID: <200905111838.45552.sr@denx.de> (raw)
In-Reply-To: <200905111227.03607.vapier@gentoo.org>

On Monday 11 May 2009 18:27:02 Mike Frysinger wrote:
> On Monday 11 May 2009 10:03:55 Stefan Roese wrote:
> > This patch brings the U-Boot MTD infrastructure in sync with the current
> > Linux MTD version (2.6.30-rc3). Biggest change is the 64bit device size
> > support and a resync of the mtdpart.c file which has seen multiple fixes
> > meanwhile.
>
> really wish there was a define to control this.  large devices are fine,
> but it sucks when majority of people dont hit this limit.

What is the drawback of this code version? I have to admit that I didn't 
compare code size, but this is the only possible drawback coming to my mind. 
And the advantages are big enough from my point of view. Being in sync with 
Linux once again not only brings 64bit device size support but removes quite a 
lot of bugs from the mtd infrastructure (for example used by UBI).

And frankly, cluttering the files with another set of #ifdef's doesn't really 
sound promising. Additionally this would make future sync's with the Linux 
version more troublesome.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-05-11 16:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 14:03 [U-Boot] [PATCH] mtd: Update MTD infrastructure to support 64bit device size Stefan Roese
2009-05-11 16:27 ` Mike Frysinger
2009-05-11 16:38   ` Stefan Roese [this message]
2009-05-11 16:57     ` Mike Frysinger
2009-05-11 20:06       ` Scott Wood
2009-05-11 17:59     ` Wolfgang Denk
2009-05-12  4:39       ` Stefan Roese
2009-05-12  5:11         ` Mike Frysinger
2009-05-12  8:14         ` Wolfgang Denk
2009-05-12  8:26           ` Stefan Roese
2009-06-03 21:49 ` Wolfgang Denk
2009-06-20  5:33 ` Dirk Behme
2009-06-20  8:52   ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-20 17:45     ` Dirk Behme
2009-06-22 12:01       ` Stefan Roese
2009-06-22 18:10         ` Dirk Behme
2009-06-22 18:21           ` Stefan Roese
2009-06-28  5:47             ` Dirk Behme
2009-06-29 14:35               ` Stefan Roese
2009-06-22 12:55   ` Stefan Roese
2009-06-22 18:12     ` Dirk Behme
2009-06-22 18:25       ` Stefan Roese
2009-06-22 18:38         ` Dirk Behme
2009-06-22 18:50           ` Scott Wood
2009-06-22 19:26             ` Stefan Roese
2009-06-22 19:49               ` Dirk Behme
2009-06-22 19:52                 ` Scott Wood
2009-06-22 20:04                   ` Dirk Behme
2009-06-22 20:08                     ` Scott Wood
2009-06-22 20:15                       ` Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905111838.45552.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox