From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] omap3: remove typedef for struct gpmc
Date: Wed, 13 May 2009 00:38:10 +0200 [thread overview]
Message-ID: <20090512223810.GI479@game.jcrosoft.org> (raw)
In-Reply-To: <4A087B7D.3020409@googlemail.com>
> >
> > -typedef struct gpmc {
> > +struct gpmc {
> > unsigned char res1[0x10];
> > unsigned int sysconfig; /* 0x10 */
> > unsigned char res2[0x4];
> > @@ -125,7 +125,7 @@ typedef struct gpmc {
> > unsigned int ecc7_result; /* 0x218 */
> > unsigned int ecc8_result; /* 0x21C */
> > unsigned int ecc9_result; /* 0x220 */
> > -} gpmc_t;
> > +};
>
> I wonder if you have the resources and like to convert all register
> structs used by OMAP3 code and remove the typedef?
>
> Else we would have a mixture of typedefs and struct usage (see e.g.
> above in sys_info.c). I would like to have it consistent, either the
> one or the other way ;) What do you think?
Fully agree
Best Regards,
J.
next prev parent reply other threads:[~2009-05-12 22:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 10:09 [U-Boot] [PATCH 0/4] omap3: clean up gpmc config strut Matthias Ludwig
2009-05-11 10:09 ` [U-Boot] [PATCH 1/4] omap3: embedd gpmc_cs into gpmc config struct Matthias Ludwig
2009-05-11 10:09 ` [U-Boot] [PATCH 2/4] omap3: remove typedef for struct gpmc Matthias Ludwig
2009-05-11 10:09 ` [U-Boot] [PATCH 3/4] omap3: replace all instances of gpmc config struct by one global Matthias Ludwig
2009-05-11 10:09 ` [U-Boot] [PATCH 4/4] omap3: use only fixed-size types inside ctrl_structs Matthias Ludwig
2009-05-11 19:24 ` [U-Boot] [PATCH 2/4] omap3: remove typedef for struct gpmc Dirk Behme
2009-05-12 8:12 ` Matthias Ludwig
2009-05-12 8:12 ` [U-Boot] [PATCHv2 1/4] omap3: embedd gpmc_cs into gpmc config struct Matthias Ludwig
2009-05-12 8:12 ` [U-Boot] [PATCHv2 2/4] omap3: remove typedefs for configuration structs Matthias Ludwig
2009-05-12 8:12 ` [U-Boot] [PATCHv2 3/4] omap3: replace all instances of gpmc config struct by one global Matthias Ludwig
2009-05-12 8:12 ` [U-Boot] [PATCHv2 4/4] omap3: use only fixed-size types inside ctrl_structs Matthias Ludwig
2009-05-12 23:05 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-13 7:32 ` Matthias Ludwig
2009-05-24 15:51 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-12 23:02 ` [U-Boot] [PATCHv2 3/4] omap3: replace all instances of gpmc config struct by one global Jean-Christophe PLAGNIOL-VILLARD
2009-05-13 5:26 ` Wolfgang Denk
2009-05-13 7:04 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-15 20:08 ` Wolfgang Denk
2009-05-12 22:59 ` [U-Boot] [PATCHv2 2/4] omap3: remove typedefs for configuration structs Jean-Christophe PLAGNIOL-VILLARD
2009-05-13 7:19 ` Matthias Ludwig
2009-05-12 22:51 ` [U-Boot] [PATCHv2 1/4] omap3: embedd gpmc_cs into gpmc config struct Jean-Christophe PLAGNIOL-VILLARD
2009-05-13 7:16 ` Matthias Ludwig
2009-05-13 7:46 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-15 7:25 ` Matthias Ludwig
2009-05-18 21:53 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-12 15:29 ` [U-Boot] [PATCH 2/4] omap3: remove typedef for struct gpmc Dirk Behme
2009-05-12 22:38 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-05-11 10:27 ` [U-Boot] [PATCH 0/4] omap3: clean up gpmc config strut Nishanth Menon
2009-05-12 6:46 ` Matthias Ludwig
2009-05-11 19:46 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512223810.GI479@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox