From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Thu, 14 May 2009 15:55:33 +0200
Subject: [U-Boot] [PATCH] cmd_ide: Fix detection problem with missing
	devices
In-Reply-To: <20090514134401.DC03E832E416@gemini.denx.de>
References: <1242278687-23685-1-git-send-email-sr@denx.de>
	<20090514134401.DC03E832E416@gemini.denx.de>
Message-ID: <200905141555.33901.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Thursday 14 May 2009 15:44:01 Wolfgang Denk wrote:
> > Currently only IDE busses are probed and all possible available devices
> > are listed in the IDE bootup log. Even when devices on the bus are not
> > available. This leads to the following output on the CPCI750:
> >
> > IDE:   Bus 0: OK Bus 1: OK
> >   Device 0: Model: HITACHI_DK23FA-20J Firm: 00M7A0A0 Ser#: 42D182
> >             Type: Hard Disk
> >             Capacity: 19077.1 MB = 18.6 GB (39070080 x 512)
> >   Device 1: Model:  Firm:  Ser#:
> >             Type: # 1F #
> >             Capacity: not available
> >   Device 2: Model: SanDisk SDCFB-128 Firm: vde 1.10 Ser#: gmo5i311404
> >             Type: Removable Hard Disk
> >             Capacity: 122.5 MB = 0.1 GB (250880 x 512)
> >   Device 3: Model:  Firm:  Ser#:
> >             Type: # 1F #
> >             Capacity: not available
>
> If my understanding is correct, then this is a bug on your hardware.

I don't think so.

> >  #endif
> > @@ -727,8 +728,12 @@ skip_bus:
> >  		if (!ide_bus_ok[IDE_BUS(i)])
> >  			continue;
> >  		ide_led(led, 1);	/* LED on       */
> > -		ide_ident(&ide_dev_desc[i]);
> > +		ret = ide_ident(&ide_dev_desc[i]);
> >  		ide_led(led, 0);	/* LED off      */
> > +		if (ret < 0) {
> > +			puts("not available\n");
> > +			continue;
> > +		}
>
> IIRC this should not be needed; normally, ide_bus_ok() should catch
> this.

No. ide_bus_ok() only checks the first drive/device on a bus. If this device 
is ok, then all drives from this bus are printed.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================