From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: ct6900: Add an option to skip video initialization
Date: Thu, 14 May 2009 17:17:43 +0200 [thread overview]
Message-ID: <200905141717.43316.sr@denx.de> (raw)
In-Reply-To: <20090514150146.22A2C832E416@gemini.denx.de>
On Thursday 14 May 2009 17:01:46 Wolfgang Denk wrote:
> > > If this should be the highest level in the call chain, then any
> > > conditional calling should be done here.
> >
> > OK, I can move the conditional calling to this level.
>
> I'm not sure.
>
> > > But - don't we already have
> > > a board_video_init() which could return proper status to abort
> > > initialization?
> >
> > This is only implemented for some video drivers (SM501, SED13806,
> > MB826xx) to return the base address for the graphics chip. The PCI
> > drivers like the ct6900 don't use this interface. Here we have other
> > means to get the base address.
> >
> > I'll move the conditional calling to the highest level and resubmit.
>
> I'd probably rahter see that you add a board_video_init() to the
> ct6900 driver, and have this bail out.
And what should this function return? The base address is already available in
the driver. Should we move this to all boards using this driver? I don't think
so.
> Anatolij, what do you thik is the best solution here?
Yes? What's your preference here?
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2009-05-14 15:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 5:25 [U-Boot] [PATCH] video: ct6900: Add an option to skip video initialization Stefan Roese
2009-05-14 13:37 ` Wolfgang Denk
2009-05-14 13:53 ` Stefan Roese
2009-05-14 14:02 ` Wolfgang Denk
2009-05-14 14:13 ` Stefan Roese
2009-05-14 15:01 ` Wolfgang Denk
2009-05-14 15:17 ` Stefan Roese [this message]
2009-05-15 0:44 ` Anatolij Gustschin
2009-05-15 5:36 ` Wolfgang Denk
2009-05-15 6:24 ` Stefan Roese
2009-05-15 0:36 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905141717.43316.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox