public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Redundant Environment: protect full sector size
Date: Fri, 15 May 2009 09:28:31 +0200	[thread overview]
Message-ID: <200905150928.32678.sr@denx.de> (raw)
In-Reply-To: <1242339363-28686-3-git-send-email-wd@denx.de>

On Friday 15 May 2009 00:16:03 Wolfgang Denk wrote:
> Several boards used different ways to specify the size of the
> protected area when enabling flash write protection for the sectors
> holding the environment variables: some used CONFIG_ENV_SIZE and
> CONFIG_ENV_SIZE_REDUND, some used CONFIG_ENV_SECT_SIZE, and some even
> a mix of both for the "normal" and the "redundant" areas.
>
> Normally, this makes no difference at all. However, things are
> different when you have to deal with boards that can come with
> different types of flash chips, which may have different sector
> sizes.
>
> Here we may have to chose CONFIG_ENV_SECT_SIZE such that it fits the
> biggest sector size, which may include several sectors on boards using
> the smaller sector flash types. In such a case, using CONFIG_ENV_SIZE
> or CONFIG_ENV_SIZE_REDUND to enable the protection may lead to the
> case that only the first of these sectors get protected, while the
> following ones aren't.
>
> This is no real problem, but it can be confusing for the user -
> especially on boards that use CONFIG_ENV_SECT_SIZE to protect the
> "normal" areas, while using CONFIG_ENV_SIZE_REDUND for the
> "redundant" area.
>
> To avoid such inconsistencies, I changed all sucn boards that I found
> to consistently use CONFIG_ENV_SECT_SIZE for protection. This should
> not cause any functional changes to the code.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Paul Ruhland
> Cc: Pantelis Antoniou <panto@intracom.gr>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Gary Jennejohn <garyj@denx.de>
> Cc: Dave Ellis <DGE@sixnetio.com>

Acked-by: Stefan Roese <sr@denx.de>

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-05-15  7:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 22:16 [U-Boot] [PATCH] TQM85xx: adapt for new flash types Wolfgang Denk
2009-05-14 22:16 ` [U-Boot] [PATCH] TQM85xx: minor config file cleanup Wolfgang Denk
2009-06-09 21:06   ` Wolfgang Denk
2009-05-14 22:16 ` [U-Boot] [PATCH] Redundant Environment: protect full sector size Wolfgang Denk
2009-05-15  7:28   ` Stefan Roese [this message]
2009-06-03 22:16   ` Wolfgang Denk
2009-06-09 21:05 ` [U-Boot] [PATCH] TQM85xx: adapt for new flash types Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905150928.32678.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox