From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 15 May 2009 09:28:31 +0200 Subject: [U-Boot] [PATCH] Redundant Environment: protect full sector size In-Reply-To: <1242339363-28686-3-git-send-email-wd@denx.de> References: <1242339363-28686-1-git-send-email-wd@denx.de> <1242339363-28686-3-git-send-email-wd@denx.de> Message-ID: <200905150928.32678.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 15 May 2009 00:16:03 Wolfgang Denk wrote: > Several boards used different ways to specify the size of the > protected area when enabling flash write protection for the sectors > holding the environment variables: some used CONFIG_ENV_SIZE and > CONFIG_ENV_SIZE_REDUND, some used CONFIG_ENV_SECT_SIZE, and some even > a mix of both for the "normal" and the "redundant" areas. > > Normally, this makes no difference at all. However, things are > different when you have to deal with boards that can come with > different types of flash chips, which may have different sector > sizes. > > Here we may have to chose CONFIG_ENV_SECT_SIZE such that it fits the > biggest sector size, which may include several sectors on boards using > the smaller sector flash types. In such a case, using CONFIG_ENV_SIZE > or CONFIG_ENV_SIZE_REDUND to enable the protection may lead to the > case that only the first of these sectors get protected, while the > following ones aren't. > > This is no real problem, but it can be confusing for the user - > especially on boards that use CONFIG_ENV_SECT_SIZE to protect the > "normal" areas, while using CONFIG_ENV_SIZE_REDUND for the > "redundant" area. > > To avoid such inconsistencies, I changed all sucn boards that I found > to consistently use CONFIG_ENV_SECT_SIZE for protection. This should > not cause any functional changes to the code. > > Signed-off-by: Wolfgang Denk > Cc: Paul Ruhland > Cc: Pantelis Antoniou > Cc: Stefan Roese > Cc: Gary Jennejohn > Cc: Dave Ellis Acked-by: Stefan Roese Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================