From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Sat, 16 May 2009 06:08:34 +0200 Subject: [U-Boot] [PATCH v4] Separate mtdparts command from jffs2 In-Reply-To: <20090515153217.77AFF832E416@gemini.denx.de> References: <1237465836-26622-1-git-send-email-sr@denx.de> <20090515153217.77AFF832E416@gemini.denx.de> Message-ID: <200905160608.34956.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, On Friday 15 May 2009 17:32:17 Wolfgang Denk wrote: > > Currently the mtdparts commands are included in the jffs2 command > > support. This doesn't make sense anymore since other commands (e.g. UBI) > > use this infrastructure as well now. This patch separates the mtdparts > > commands from the jffs2 commands making it possible to only select > > mtdparts when no JFFS2 support is needed. > > > > Signed-off-by: Stefan Roese > > Signed-off-by: Kyungmin Park > > As it turns out, that split was incomplete or incorrect. > > It seems that since commit 68d7d65100 we have two different, > incompatible implementations of mtdparts_init() - one in > common/cmd_jffs2.c and another one in common/cmd_mtdparts.c > > When NAND and JFFS2 and MTDPARTS are enabled at the same time, the > mtdparts_init() from common/cmd_mtdparts.c is called, which obviously > does not pereform the required intializations for JFFS2: all JFFS2 > related commands just return without any error messages but also > without any useful output either. Sorry about this. > Please provide a fix! OK, I'll try to come up with a patch quickly. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================