From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand_init: use loff_t for offset
Date: Wed, 20 May 2009 18:55:32 +0200 [thread overview]
Message-ID: <20090520165532.GC12379@game.jcrosoft.org> (raw)
In-Reply-To: <20090519223113.GB27443@b07421-ec1.am.freescale.net>
On 17:31 Tue 19 May , Scott Wood wrote:
> On Sat, May 16, 2009 at 02:27:40PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > -static inline int nand_erase(nand_info_t *info, off_t off, size_t size)
> > +static inline int nand_erase(nand_info_t *info, loff_t off, size_t size)
>
> "size" should probably be loff_t (or something similarly sized) as well,
> or erasing an entire large device at once could be awkward.
so we need to update the struct erase_info too as it handle a u_int32_t
Best Regards,
J.
next prev parent reply other threads:[~2009-05-20 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-16 12:27 [U-Boot] [PATCH] nand_init: use loff_t for offset Jean-Christophe PLAGNIOL-VILLARD
2009-05-19 22:31 ` Scott Wood
2009-05-20 16:55 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2009-06-22 20:29 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090520165532.GC12379@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox