[U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion

Jean-Christophe PLAGNIOL-VILLARD
2009-05-26T21:44:04Z

On 16:30 Tue 26 May , Scott Wood wrote:
> On Tue, May 26, 2009 at 01:48:08AM -0700, Prafulla Wadaskar wrote:
> > Good Feedback...
> > The name board_nand_init() is confusing here.... Why the board specific code is in drivers/mtd/nand/?
> > Whereas I can see more references in board/*
> > But looking other code references in this folder your feedback stands valid
> > BTW: the arch_nand_init() or device_nand_init() is the right name
> > here...Scott need to suggest on this since it involves rework on other
> > drivers too.
>
> Rather than just change the name, we should do something more similar to
> Linux, where the driver is called with an initfunc (or explicitly by
> board/arch code), which in turn calls nand_scan[1], and places itself at
> the appropriate spot in nand_chip[].
>
> nand_init and nand_init_chip would go away.
the initcall patch I send few days ago will clearly help on this too

Best Regards,
J.