From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 26 May 2009 09:57:29 +0200 Subject: [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support In-Reply-To: <200905260940.50045.sr@denx.de> References: <73173D32E9439E4ABB5151606C3E19E201CF9E6BB0@SC-VEXCH1.marvell.com> <200905260940.50045.sr@denx.de> Message-ID: <200905260957.29423.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 26 May 2009 09:40:49 Stefan Roese wrote: > So could you please split this Sheevaplug patch and submit the NAND driver > in a separate patch (CC to Scott Wood as NAND custodian)? I just tried including the NAND driver from this patch into drivers/mtd/nand. Seems that a few things are still missing. struct kwnandf_registers not defined KW_NANDF_BASE not defined And is KW_NANDF_BASE not the same as CONFIG_SYS_NAND_BASE defined in the board config header (sheevaplug.h in your case)? Then we should remove one of those defines. I couldn't find those defines/structs in the Sheevaplug patch either btw. Could be that I missed something here though. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================