* [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support [not found] <200905260912.43517.sr@denx.de> @ 2009-05-26 7:28 ` Prafulla Wadaskar 2009-05-26 7:40 ` Stefan Roese 0 siblings, 1 reply; 9+ messages in thread From: Prafulla Wadaskar @ 2009-05-26 7:28 UTC (permalink / raw) To: u-boot > -----Original Message----- > From: Stefan Roese [mailto:sr at denx.de] > Sent: Tuesday, May 26, 2009 12:43 PM > To: Prafulla Wadaskar > Subject: Re: [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support > > Hi Prafulla, > > On Thursday 21 May 2009 22:24:29 Prafulla Wadaskar wrote: > > Kirkwood family controllers are highly integrated SOCs based on > > Feroceon-88FR131/Sheeva-88SV131 cpu core. > > Do you also have a NAND driver for Kirkwood in your queue? > I'm asking since I need NAND support for my custom board. If > you don't have any I will port the one from the 1.1.4 Marvell > version to mainline. Hi Stefan No need, NAND support is already mainlined in u-boot, you just need to use it I have used it for Sheevaplug board support please see the patch http://lists.denx.de/pipermail/u-boot/2009-May/053158.html Please kindly keep practice asking questions on u-boot at lists.denx.de so that everyone in need can use the information, vice versa answer your query Regards.. Prafulla . . ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support 2009-05-26 7:28 ` [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support Prafulla Wadaskar @ 2009-05-26 7:40 ` Stefan Roese 2009-05-26 7:57 ` Stefan Roese 2009-05-26 8:48 ` [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion Prafulla Wadaskar 0 siblings, 2 replies; 9+ messages in thread From: Stefan Roese @ 2009-05-26 7:40 UTC (permalink / raw) To: u-boot On Tuesday 26 May 2009 09:28:29 Prafulla Wadaskar wrote: > > Do you also have a NAND driver for Kirkwood in your queue? > > I'm asking since I need NAND support for my custom board. If > > you don't have any I will port the one from the 1.1.4 Marvell > > version to mainline. > > Hi Stefan > No need, NAND support is already mainlined in u-boot, you just need to use > it I have used it for Sheevaplug board support please see the patch > http://lists.denx.de/pipermail/u-boot/2009-May/053158.html I know that NAND support is generally available in U-Boot. But what's currently missing is the platform/board specific driver for Kirkwood. Seems that you included the Kirkwood NAND driver into your Sheevaplug support patch. Good. But this driver should be placed in drivers/mtd/nand so that other Kirkwood boards can use it as well. So could you please split this Sheevaplug patch and submit the NAND driver in a separate patch (CC to Scott Wood as NAND custodian)? Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support 2009-05-26 7:40 ` Stefan Roese @ 2009-05-26 7:57 ` Stefan Roese 2009-05-26 8:17 ` Prafulla Wadaskar 2009-05-26 8:48 ` [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion Prafulla Wadaskar 1 sibling, 1 reply; 9+ messages in thread From: Stefan Roese @ 2009-05-26 7:57 UTC (permalink / raw) To: u-boot On Tuesday 26 May 2009 09:40:49 Stefan Roese wrote: > So could you please split this Sheevaplug patch and submit the NAND driver > in a separate patch (CC to Scott Wood as NAND custodian)? I just tried including the NAND driver from this patch into drivers/mtd/nand. Seems that a few things are still missing. struct kwnandf_registers not defined KW_NANDF_BASE not defined And is KW_NANDF_BASE not the same as CONFIG_SYS_NAND_BASE defined in the board config header (sheevaplug.h in your case)? Then we should remove one of those defines. I couldn't find those defines/structs in the Sheevaplug patch either btw. Could be that I missed something here though. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support 2009-05-26 7:57 ` Stefan Roese @ 2009-05-26 8:17 ` Prafulla Wadaskar 2009-05-26 8:25 ` Stefan Roese 0 siblings, 1 reply; 9+ messages in thread From: Prafulla Wadaskar @ 2009-05-26 8:17 UTC (permalink / raw) To: u-boot > -----Original Message----- > From: Stefan Roese [mailto:sr at denx.de] > Sent: Tuesday, May 26, 2009 1:27 PM > To: u-boot at lists.denx.de > Cc: Prafulla Wadaskar > Subject: Re: [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support > > On Tuesday 26 May 2009 09:40:49 Stefan Roese wrote: > > So could you please split this Sheevaplug patch and submit the NAND > > driver in a separate patch (CC to Scott Wood as NAND custodian)? > > I just tried including the NAND driver from this patch into > drivers/mtd/nand. > Seems that a few things are still missing. > > struct kwnandf_registers not defined > KW_NANDF_BASE not defined I hope your are using in old patch version Please use http://lists.denx.de/pipermail/u-boot/2009-May/053110.html > > And is KW_NANDF_BASE not the same as CONFIG_SYS_NAND_BASE > defined in the board config header (sheevaplug.h in your > case)? Then we should remove one of those defines. I have used KW_NANDF_BASE only reference http://lists.denx.de/pipermail/u-boot/2009-May/053110.html I will check about CONFIG_SYS_NAND_BASE support Regards.. Prafulla . . ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support 2009-05-26 8:17 ` Prafulla Wadaskar @ 2009-05-26 8:25 ` Stefan Roese 0 siblings, 0 replies; 9+ messages in thread From: Stefan Roese @ 2009-05-26 8:25 UTC (permalink / raw) To: u-boot On Tuesday 26 May 2009 10:17:45 Prafulla Wadaskar wrote: > > I just tried including the NAND driver from this patch into > > drivers/mtd/nand. > > Seems that a few things are still missing. > > > > struct kwnandf_registers not defined > > KW_NANDF_BASE not defined > > I hope your are using in old patch version Please use > http://lists.denx.de/pipermail/u-boot/2009-May/053110.html Yes, seems that I used not the latest version. Thanks for checking. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion 2009-05-26 7:40 ` Stefan Roese 2009-05-26 7:57 ` Stefan Roese @ 2009-05-26 8:48 ` Prafulla Wadaskar 2009-05-26 8:57 ` Stefan Roese 2009-05-26 21:30 ` Scott Wood 1 sibling, 2 replies; 9+ messages in thread From: Prafulla Wadaskar @ 2009-05-26 8:48 UTC (permalink / raw) To: u-boot > -----Original Message----- > From: Stefan Roese [mailto:sr at denx.de] > Sent: Tuesday, May 26, 2009 1:11 PM > To: Prafulla Wadaskar > Cc: u-boot at lists.denx.de > Subject: Re: [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support > > On Tuesday 26 May 2009 09:28:29 Prafulla Wadaskar wrote: > > > Do you also have a NAND driver for Kirkwood in your queue? > > > I'm asking since I need NAND support for my custom board. If you > > > don't have any I will port the one from the 1.1.4 Marvell > version to > > > mainline. > > > > Hi Stefan > > No need, NAND support is already mainlined in u-boot, you > just need to > > use it I have used it for Sheevaplug board support please see the > > patch http://lists.denx.de/pipermail/u-boot/2009-May/053158.html > > I know that NAND support is generally available in U-Boot. > But what's currently missing is the platform/board specific > driver for Kirkwood. Seems that you included the Kirkwood > NAND driver into your Sheevaplug support patch. > Good. But this driver should be placed in drivers/mtd/nand so > that other Kirkwood boards can use it as well. Good Feedback... The name board_nand_init() is confusing here.... Why the board specific code is in drivers/mtd/nand/? Whereas I can see more references in board/* But looking other code references in this folder your feedback stands valid BTW: the arch_nand_init() or device_nand_init() is the right name here...Scott need to suggest on this since it involves rework on other drivers too. Meanwhile for my next patch update I will move nand.c from sheevaplug to drivers/mtd/nand/kirkwood_nand.c Regards.. Prafulla . . ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion 2009-05-26 8:48 ` [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion Prafulla Wadaskar @ 2009-05-26 8:57 ` Stefan Roese 2009-05-26 21:30 ` Scott Wood 1 sibling, 0 replies; 9+ messages in thread From: Stefan Roese @ 2009-05-26 8:57 UTC (permalink / raw) To: u-boot On Tuesday 26 May 2009 10:48:08 Prafulla Wadaskar wrote: > > I know that NAND support is generally available in U-Boot. > > But what's currently missing is the platform/board specific > > driver for Kirkwood. Seems that you included the Kirkwood > > NAND driver into your Sheevaplug support patch. > > Good. But this driver should be placed in drivers/mtd/nand so > > that other Kirkwood boards can use it as well. > > Good Feedback... > The name board_nand_init() is confusing here.... Why the board specific > code is in drivers/mtd/nand/? Perhaps somewhat historic reasons.... > Whereas I can see more references in board/* Yes, this needs more cleanup/moving of those drivers into this common place. > But looking other code references in this folder your feedback stands valid > BTW: the arch_nand_init() or device_nand_init() is the right name > here...Scott need to suggest on this since it involves rework on other > drivers too. You should use board_nand_init() for now. We could move to another name in the future. > Meanwhile for my next patch update I will move nand.c from sheevaplug to > drivers/mtd/nand/kirkwood_nand.c Great. Thanks. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion 2009-05-26 8:48 ` [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion Prafulla Wadaskar 2009-05-26 8:57 ` Stefan Roese @ 2009-05-26 21:30 ` Scott Wood 2009-05-26 21:44 ` Jean-Christophe PLAGNIOL-VILLARD 1 sibling, 1 reply; 9+ messages in thread From: Scott Wood @ 2009-05-26 21:30 UTC (permalink / raw) To: u-boot On Tue, May 26, 2009 at 01:48:08AM -0700, Prafulla Wadaskar wrote: > Good Feedback... > The name board_nand_init() is confusing here.... Why the board specific code is in drivers/mtd/nand/? > Whereas I can see more references in board/* > But looking other code references in this folder your feedback stands valid > BTW: the arch_nand_init() or device_nand_init() is the right name > here...Scott need to suggest on this since it involves rework on other > drivers too. Rather than just change the name, we should do something more similar to Linux, where the driver is called with an initfunc (or explicitly by board/arch code), which in turn calls nand_scan[1], and places itself at the appropriate spot in nand_chip[]. nand_init and nand_init_chip would go away. -Scott [1] Or nand_scan_ident and nand_scan_tail. Some drivers (eLBC) would like to do things in between, but the current driver init mechanism doesn't allow that (so small/large page has to be hardcoded, not detected). It would also allow more than just one address word to be passed to the driver as identification, which would remove some more code and complexity from the eLBC driver. ^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion 2009-05-26 21:30 ` Scott Wood @ 2009-05-26 21:44 ` Jean-Christophe PLAGNIOL-VILLARD 0 siblings, 0 replies; 9+ messages in thread From: Jean-Christophe PLAGNIOL-VILLARD @ 2009-05-26 21:44 UTC (permalink / raw) To: u-boot On 16:30 Tue 26 May , Scott Wood wrote: > On Tue, May 26, 2009 at 01:48:08AM -0700, Prafulla Wadaskar wrote: > > Good Feedback... > > The name board_nand_init() is confusing here.... Why the board specific code is in drivers/mtd/nand/? > > Whereas I can see more references in board/* > > But looking other code references in this folder your feedback stands valid > > BTW: the arch_nand_init() or device_nand_init() is the right name > > here...Scott need to suggest on this since it involves rework on other > > drivers too. > > Rather than just change the name, we should do something more similar to > Linux, where the driver is called with an initfunc (or explicitly by > board/arch code), which in turn calls nand_scan[1], and places itself at > the appropriate spot in nand_chip[]. > > nand_init and nand_init_chip would go away. the initcall patch I send few days ago will clearly help on this too Best Regards, J. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-05-26 21:44 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200905260912.43517.sr@denx.de>
2009-05-26 7:28 ` [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support Prafulla Wadaskar
2009-05-26 7:40 ` Stefan Roese
2009-05-26 7:57 ` Stefan Roese
2009-05-26 8:17 ` Prafulla Wadaskar
2009-05-26 8:25 ` Stefan Roese
2009-05-26 8:48 ` [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion Prafulla Wadaskar
2009-05-26 8:57 ` Stefan Roese
2009-05-26 21:30 ` Scott Wood
2009-05-26 21:44 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox