From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion
Date: Tue, 26 May 2009 23:44:04 +0200 [thread overview]
Message-ID: <20090526214404.GA30039@game.jcrosoft.org> (raw)
In-Reply-To: <20090526213052.GC4669@b07421-ec1.am.freescale.net>
On 16:30 Tue 26 May , Scott Wood wrote:
> On Tue, May 26, 2009 at 01:48:08AM -0700, Prafulla Wadaskar wrote:
> > Good Feedback...
> > The name board_nand_init() is confusing here.... Why the board specific code is in drivers/mtd/nand/?
> > Whereas I can see more references in board/*
> > But looking other code references in this folder your feedback stands valid
> > BTW: the arch_nand_init() or device_nand_init() is the right name
> > here...Scott need to suggest on this since it involves rework on other
> > drivers too.
>
> Rather than just change the name, we should do something more similar to
> Linux, where the driver is called with an initfunc (or explicitly by
> board/arch code), which in turn calls nand_scan[1], and places itself at
> the appropriate spot in nand_chip[].
>
> nand_init and nand_init_chip would go away.
the initcall patch I send few days ago will clearly help on this too
Best Regards,
J.
prev parent reply other threads:[~2009-05-26 21:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200905260912.43517.sr@denx.de>
2009-05-26 7:28 ` [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support Prafulla Wadaskar
2009-05-26 7:40 ` Stefan Roese
2009-05-26 7:57 ` Stefan Roese
2009-05-26 8:17 ` Prafulla Wadaskar
2009-05-26 8:25 ` Stefan Roese
2009-05-26 8:48 ` [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support NAND discussion Prafulla Wadaskar
2009-05-26 8:57 ` Stefan Roese
2009-05-26 21:30 ` Scott Wood
2009-05-26 21:44 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090526214404.GA30039@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox