public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ira Snyder <iws@ovro.caltech.edu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC/PATCH] 83xx: Add support for using the fsl_dma driver
Date: Thu, 28 May 2009 13:55:18 -0700	[thread overview]
Message-ID: <20090528205518.GD25993@ovro.caltech.edu> (raw)
In-Reply-To: <1243023871-23506-1-git-send-email-ptyser@xes-inc.com>

On Fri, May 22, 2009 at 03:24:31PM -0500, Peter Tyser wrote:
> Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
> ---
> 
> I don't have any 83xx boards to try this on, but I verified the dma code
> still works on an 86xx board.  An easy way to test this change (Ira?)
> would be to enable CONFIG_FSL_DMA and CONFIG_SYS_DMA_MEMTEST after the
> "85xx/86xx dma updates" and "Add optional dma transfers to mtest"
> patch series have been applied.
> 
> This patch dirties up the fsl_dma code a bit and no one is currently
> using the 83xx dma code, so its value is debatable.  Maybe others will
> find it useful or want to include it to support the 83xx down the road.

Hello Peter,

I've given this patch (along with the two required patch series) a whirl
on my MPC8349EMDS board. As best I can tell, it works exactly as
expected. I've also reviewed the changes for the 83xx controller, and
they look great.  You've done a great job of minimizing the code
differences between the 83xx and 86xx controllers.

It would definitely make some of my future work easier if this gets
accepted. Feel free to add my reviewed-by and tested-by to your patch.

Reviewed-by: Ira W. Snyder <iws@ovro.caltech.edu>
Tested-by: Ira W. Snyder <iws@ovro.caltech.edu>

Thanks,
Ira

      reply	other threads:[~2009-05-28 20:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22 20:24 [U-Boot] [RFC/PATCH] 83xx: Add support for using the fsl_dma driver Peter Tyser
2009-05-28 20:55 ` Ira Snyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090528205518.GD25993@ovro.caltech.edu \
    --to=iws@ovro.caltech.edu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox