From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kim Phillips <kim.phillips@freescale.com>
Date: Mon, 1 Jun 2009 10:54:27 -0500
Subject: [U-Boot] [PATCH] The omap3 L2 cache enable/disable function to
 omap3 dependent code
In-Reply-To: <b64afca20906010314s524cf118q6c5ee6b4b3d2626e@mail.gmail.com>
References: <b64afca20906010314s524cf118q6c5ee6b4b3d2626e@mail.gmail.com>
Message-ID: <20090601105427.47afbbc8.kim.phillips@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, 1 Jun 2009 19:14:49 +0900
"Kim, Heung Jun" <riverful@gmail.com> wrote:

> CC: Dirk Behme <dirk.behme@googlemail.com>
> Signed-off-by: HeungJun, Kim <riverful.kim@samsung.com>
> 
> ---
> 
> The L2 cache enable/disable function in the cpu/arm_cortexa8/cpu.c moved
> to cpu/arm_cortexa8/omap3/cache.c.
> 
> This patches fixes the First issue in the following
> 
> http://lists.denx.de/pipermail/u-boot/2009-May/053433.html
> 
> The Second issue is fixed by
> 
> http://lists.denx.de/pipermail/u-boot/2009-May/053490.html
> 

Hi Riverful,

1. the patch title is missing the verb 'move'
2. your signoff is in the correct location, however the commit message
is not.  It belongs above the line with the '---'.
3. while making backreferences by pointing to messages in the list
archive is cool, they don't stand the test of time - the URL may one
day cease to exist.  So it is better to either reference a commitish in
the repository itself, or simply restate/copy the original data.

Thanks,

Kim