From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kim Phillips Date: Mon, 1 Jun 2009 12:49:41 -0500 Subject: [U-Boot] [PATCH] The omap3 L2 cache enable/disable function to omap3 dependent code In-Reply-To: <4A2405DD.7040106@googlemail.com> References: <20090601105427.47afbbc8.kim.phillips@freescale.com> <4A2405DD.7040106@googlemail.com> Message-ID: <20090601124941.c2be21af.kim.phillips@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 01 Jun 2009 18:46:21 +0200 Dirk Behme wrote: > > 2. your signoff is in the correct location, however the commit message > > is not. It belongs above the line with the '---'. > > 3. while making backreferences by pointing to messages in the list > > archive is cool, they don't stand the test of time - the URL may one > > day cease to exist. So it is better to either reference a commitish in > > the repository itself, or simply restate/copy the original data. > > As long as references to the mailing list archive are in patch comment > (below --- as they are here) and don't go into git I think it's fine > to use them. agreed (and I just did that myself in another thread) - it's just that, in this case, the referenced subject matter needs to go in the git commit message (see 2 above). Kim