From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] Add display cpuinfo for Atmel at91 arm926ejs based cores
Date: Mon, 1 Jun 2009 22:20:42 +0200 [thread overview]
Message-ID: <20090601202042.GF6399@game.jcrosoft.org> (raw)
In-Reply-To: <20090601195953.GA4991@galileo>
On 21:59 Mon 01 Jun , Stelian Pop wrote:
> Hi R?my,
>
> I do have a few comments, see below:
>
> On Mon, Jun 01, 2009 at 08:21:42PM +0200, Remy Bohmer wrote:
>
> > V2 reworked comments from Jean-Christophe PLAGNIOL-VILLARD
> [...]
>
> > +COBJS-$(CONFIG_DISPLAY_CPUINFO) +=cpuinfo.o
>
> missing space ?
>
> > + switch ((cidr & AT91_CIDR_EPROC) >> 5) {
> > + /* 0x1 = ARM946ES, 0x2 = ARM7TDMI, 0x4 = ARM920T */
> > + case 0x5: txt = "ARM926EJS"; break;
> > + default: txt = "undefined"; break;
>
> since there are only four choices (until now at least...), why not
> put the 'txt' for all of them ?
We need to use the ifdef to reduce the size impact and not implement
non-supported code is important
>
> and the 'undefined' string is not a good choice: it represents a
> configuration not known to U-Boot, but its numeric value is well
> defined. So I suggest you change this to 'unknown', or even better,
> 'unknown: 0xfoo'.
I agree
Best Regards,
J.
prev parent reply other threads:[~2009-06-01 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-02 20:06 [U-Boot] [patch] Add display cpuinfo for Atmel at91sam9261 Cores Remy Bohmer
2009-05-18 20:25 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-01 18:21 ` [U-Boot] [PATCH V2] Add display cpuinfo for Atmel at91 arm926ejs based cores Remy Bohmer
2009-06-01 18:21 ` [U-Boot] [PATCH] Enable display CPU-Info for at91sam9261 Remy Bohmer
2009-06-01 20:03 ` Stelian Pop
2009-06-01 20:22 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-02 19:17 ` Remy Bohmer
2009-06-01 19:59 ` [U-Boot] [PATCH V2] Add display cpuinfo for Atmel at91 arm926ejs based cores Stelian Pop
2009-06-01 20:20 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601202042.GF6399@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox