From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Mon, 1 Jun 2009 22:20:42 +0200
Subject: [U-Boot] [PATCH V2] Add display cpuinfo for Atmel at91
	arm926ejs based	cores
In-Reply-To: <20090601195953.GA4991@galileo>
References: <20090518202543.GH17539@game.jcrosoft.org>
	<1243880503-25092-1-git-send-email-linux@bohmer.net>
	<20090601195953.GA4991@galileo>
Message-ID: <20090601202042.GF6399@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 21:59 Mon 01 Jun     , Stelian Pop wrote:
> Hi R?my,
> 
> I do have a few comments, see below:
> 
> On Mon, Jun 01, 2009 at 08:21:42PM +0200, Remy Bohmer wrote:
> 
> >  V2 reworked comments from Jean-Christophe PLAGNIOL-VILLARD
> [...]
> 
> > +COBJS-$(CONFIG_DISPLAY_CPUINFO) +=cpuinfo.o
> 
> missing space ?
> 
> > +	switch ((cidr & AT91_CIDR_EPROC) >> 5) {
> > +	 /* 0x1 = ARM946ES, 0x2 = ARM7TDMI, 0x4 = ARM920T */
> > +	case 0x5: txt = "ARM926EJS";	break;
> > +	default:  txt = "undefined";	break;
> 
> since there are only four choices (until now at least...), why not
> put the 'txt' for all of them ?
We need to use the ifdef to reduce the size impact and not implement
non-supported code is important
> 
> and the 'undefined' string is not a good choice: it represents a
> configuration not known to U-Boot, but its numeric value is well
> defined. So I suggest you change this to 'unknown', or even better,
> 'unknown: 0xfoo'.
I agree

Best Regards,
J.