From: David Brownell <david-b@pacbell.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM DaVinci: EMIF settings
Date: Wed, 3 Jun 2009 14:12:29 -0700 [thread overview]
Message-ID: <200906031412.29237.david-b@pacbell.net> (raw)
In-Reply-To: <20090531120347.GA10249@game.jcrosoft.org>
On Sunday 31 May 2009, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 19:46 Sun 03 May , Thomas Lange wrote:
> > NAND module should not modify EMIF registers unrelated to CS2
> > that is used for NAND, i.e. do not modify EWAIT config register
> > or registers for other Chip Selects.
> >
> > Without this patch, EMIF configurations made in board_init()
> > will be invalidated.
> >
> > Signed-off-by: Thomas Lange <thomas@corelatus.se>
> > ---
> David, Sandeep
> is one of you can test it on some boards too?
I'd just merge it as-is (it builds, yes?).
That code is *extremely* dubious already, and the boards
using that driver only use NAND on CS2. Code reconfiguring
other chipselects is broken.
That code is already dm6446-specific. I have one dm6446
board, which only uses CS2 ... so the only error I could
turn up would be a build error.
next prev parent reply other threads:[~2009-06-03 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-03 17:46 [U-Boot] [PATCH] ARM DaVinci: EMIF settings Thomas Lange
2009-05-31 12:03 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-03 21:12 ` David Brownell [this message]
2009-06-07 11:58 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906031412.29237.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox