From: Daniel Mack <daniel@caiaq.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] Add generic bit operations
Date: Thu, 4 Jun 2009 13:54:42 +0200 [thread overview]
Message-ID: <20090604115442.GI26688@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090604114717.3763B832E416@gemini.denx.de>
On Thu, Jun 04, 2009 at 01:47:17PM +0200, Wolfgang Denk wrote:
> > +static inline void clear_bit(int nr, volatile unsigned long *addr)
> > +{
> > + unsigned long mask = BIT_MASK(nr);
> > + unsigned long *p = ((unsigned long *)addr) + BIT_WORD(nr);
> > +
> > + *p &= ~mask;
> > +}
>
> Such code has no chance of being accepted anyway.
>
> It tries to be generic and does not care if you use it on memory or
> device addresses - but for device addresses, the use of proper I/O
> accessor functions is mandatory.
And the functions I removed from asm-arm/bitops.h did that?
next prev parent reply other threads:[~2009-06-04 11:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 10:27 [U-Boot] (no subject) Daniel Mack
2009-06-04 10:27 ` [U-Boot] [PATCH 1/3] ARM: remove unused bit operations Daniel Mack
2009-06-04 10:27 ` [U-Boot] [PATCH 2/3] Add generic " Daniel Mack
2009-06-04 10:27 ` [U-Boot] [PATCH 3/3] ARM: add unaligned macros Daniel Mack
2009-06-04 17:42 ` Daniel Mack
2009-06-04 19:03 ` Wolfgang Denk
2009-06-04 19:23 ` Daniel Mack
2009-06-05 3:21 ` Stefan Roese
2009-06-04 11:45 ` [U-Boot] [PATCH 2/3] Add generic bit operations Wolfgang Denk
2009-06-04 11:48 ` Daniel Mack
2009-06-04 11:58 ` Wolfgang Denk
2009-06-04 11:47 ` Wolfgang Denk
2009-06-04 11:54 ` Daniel Mack [this message]
[not found] ` <20090604115922.E6893832E416@gemini.denx.de>
2009-06-04 18:00 ` Daniel Mack
2009-06-04 18:18 ` Stefan Roese
2009-06-04 19:06 ` Wolfgang Denk
2009-06-05 20:44 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-07 22:41 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604115442.GI26688@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox