public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] 74xx_7xx: CPCI750: Add loadpci command
Date: Fri, 5 Jun 2009 05:39:52 +0200	[thread overview]
Message-ID: <200906050539.52686.sr@denx.de> (raw)
In-Reply-To: <200906041940.19640.matthias.fuchs@esd-electronics.com>

Hi Matthias,

On Thursday 04 June 2009 19:40:19 Matthias Fuchs wrote:
> doen't it make sense to use/extend the code from
> board/esd/common/cmd_loadpci.c in stead it copying this code? Even that
> code is running on 4xx only, it should be simple to modify it for cpci750.
> Adding support for bootvx should be simple also.

I thought about this too but didn't do it mainly because of those reasons:

a) As you already mentioned the current code in common is 4xx specific.

b) The parameters used to identify the image type are incompatible on
   both platforms. "1" is used for booting a script on 4xx and VxWorks
   on CPCI750.

c) I have no means of testing any changes in this code on 4xx and/or
   750.

So if you still think this should be unified then I need your assistance here. 
You would need to help me testing those changes on both platforms. Please let 
me know if you can do this.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-06-05  3:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-04 11:35 [U-Boot] [PATCH 1/5] 74xx_7xx: CPCI750: Add commandline editing/history Stefan Roese
2009-06-04 11:35 ` [U-Boot] [PATCH 2/5] 74xx_7xx: CPCI750: Add loadpci command Stefan Roese
2009-06-04 17:40   ` Matthias Fuchs
2009-06-05  3:39     ` Stefan Roese [this message]
2009-06-05 10:54       ` Matthias Fuchs
2009-06-12 12:53   ` Wolfgang Denk
2009-06-04 11:35 ` [U-Boot] [PATCH 3/5] 74xx_7xx: CPCI750: Minor coding style cleanup of cpci750.c Stefan Roese
2009-06-12 12:54   ` Wolfgang Denk
2009-06-04 11:35 ` [U-Boot] [PATCH 4/5] 74xx_7xx: CPCI750: Enable access to PCI function > 0 Stefan Roese
2009-06-04 17:43   ` Matthias Fuchs
2009-06-04 11:35 ` [U-Boot] [PATCH 5/5] 74xx_7xx: CPCI750: Add CPCI adapter/target support Stefan Roese
2009-06-12 12:56   ` Wolfgang Denk
2009-06-12 12:52 ` [U-Boot] [PATCH 1/5] 74xx_7xx: CPCI750: Add commandline editing/history Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906050539.52686.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox