From: Daniel Mack <daniel@caiaq.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] Add generic bit operations
Date: Mon, 8 Jun 2009 00:41:58 +0200 [thread overview]
Message-ID: <20090607224158.GM26148@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090605204421.GC25032@game.jcrosoft.org>
On Fri, Jun 05, 2009 at 10:44:21PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > This adds generic bit operations for all platforms and enables includes
> > the implementations from asm-arm.
> >
> > Code taken from Linux kernel.
> >
> the __set_bit, __clear_bit, __change_bit & co generic is used on arm ok
Do you mean it worked before? Or are you referring to the version I
posted which you think is ok?
> but be aware that we use it in U-Boot so NACK
You use what? The functions I removed? I doubt that. The functions
marked 'external' have no implementation, and I also don't believe the
static inlines did the right thing (note the shift operations).
> and please do not rename __xxx by xxx they do not mean the same think
>
> the __xxx can be re-ordered and the xxx not
Sorry, I don't get it - what's your point about the status quo in the
sources and about the patches?
Daniel
prev parent reply other threads:[~2009-06-07 22:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 10:27 [U-Boot] (no subject) Daniel Mack
2009-06-04 10:27 ` [U-Boot] [PATCH 1/3] ARM: remove unused bit operations Daniel Mack
2009-06-04 10:27 ` [U-Boot] [PATCH 2/3] Add generic " Daniel Mack
2009-06-04 10:27 ` [U-Boot] [PATCH 3/3] ARM: add unaligned macros Daniel Mack
2009-06-04 17:42 ` Daniel Mack
2009-06-04 19:03 ` Wolfgang Denk
2009-06-04 19:23 ` Daniel Mack
2009-06-05 3:21 ` Stefan Roese
2009-06-04 11:45 ` [U-Boot] [PATCH 2/3] Add generic bit operations Wolfgang Denk
2009-06-04 11:48 ` Daniel Mack
2009-06-04 11:58 ` Wolfgang Denk
2009-06-04 11:47 ` Wolfgang Denk
2009-06-04 11:54 ` Daniel Mack
[not found] ` <20090604115922.E6893832E416@gemini.denx.de>
2009-06-04 18:00 ` Daniel Mack
2009-06-04 18:18 ` Stefan Roese
2009-06-04 19:06 ` Wolfgang Denk
2009-06-05 20:44 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-07 22:41 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090607224158.GM26148@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox