public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nand/mpc512x: Add MPC512x NAND support (NFC)
Date: Mon, 8 Jun 2009 19:00:52 +0200	[thread overview]
Message-ID: <200906081900.52451.sr@denx.de> (raw)
In-Reply-To: <200906081254.45715.kosmo@semihalf.com>

On Monday 08 June 2009 12:54:45 Piotr Zi?cik wrote:
> Monday 08 June 2009 09:51:15 Stefan Roese wrote:
> > This patch adds NAND Flash Controller driver for MPC5121 revision 2.
> > All device features, except hardware ECC and power management, are
> > supported.
> >
> > This NFC driver replaces the one orignally posted by John Rigby:
> >
> > "[PATCH] Freescale NFC NAND driver"
> >
> > It's a port of the Linux driver version posted by Piotr Ziecik a few
> > weeks ago. Using this driver has the following advantages (from my poont
> > of view):
> >
> > - Compatibility with the Linux NAND driver (e.g. ECC usage)
>
> I do not see ADS5121 support in posted driver code. ADS5121 board controls
> NAND chip selects via external CPLD and do not use controller chip select
> signals. Linux driver has workaround for this special case.

Yes, I know. I explicitly removed this code because of two reasons:

a) My basic testing platform was the esd mecp5123 board.

b) I did some quick tests on the MCP5121ADS with this code (without
   this ADS specific chip-select handling) and didn't see any error.

So I suggest to add the code as is for now. Such board specific routines can 
be added later on when really needed.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2009-06-08 17:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08  7:51 [U-Boot] [PATCH] nand/mpc512x: Add MPC512x NAND support (NFC) Stefan Roese
2009-06-08 10:41 ` Wolfgang Denk
2009-06-08 16:51   ` Stefan Roese
2009-06-08 10:54 ` Piotr Zięcik
2009-06-08 17:00   ` Stefan Roese [this message]
2009-06-08 18:08     ` Wolfgang Denk
2009-06-08 18:24       ` Stefan Roese
2009-06-08 19:09         ` John Rigby
2009-06-09  7:28           ` Stefan Roese
2009-06-08 19:46         ` Wolfgang Denk
2009-06-09  7:31           ` Stefan Roese
2009-06-09  8:46             ` Wolfgang Denk
2009-06-09  9:01               ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906081900.52451.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox