[U-Boot] [PATCH] nand/mpc512x: Add MPC512x NAND support (NFC)

John Rigby
2009-06-08T19:09:01Z

Stephan,

Are you able to read the second half of the NAND? The NAND package on the
ADS contains two chips with two separate chip selects. Without the chip
select code you will likely only see 512M instead of 1G.

John

On Mon, Jun 8, 2009 at 12:24 PM, Stefan Roese <sr@denx.de> wrote:

> On Monday 08 June 2009 20:08:21 Wolfgang Denk wrote:
> > > > I do not see ADS5121 support in posted driver code. ADS5121 board
> > > > controls NAND chip selects via external CPLD and do not use
> controller
> > > > chip select signals. Linux driver has workaround for this special
> case.
> > >
> > > Yes, I know. I explicitly removed this code because of two reasons:
> >
> > Argh. That's a really stupid thing to do.
>
> Did you actually see the code? Did you see the board specific code added to
> the "common" NFC driver code? This is not really something I like to see in
> common drivers. And such code usually get's a NAK from you as well.
>
> > > a) My basic testing platform was the esd mecp5123 board.
> > >
> > > b) I did some quick tests on the MCP5121ADS with this code (without
> > > this ADS specific chip-select handling) and didn't see any error.
> > >
> > > So I suggest to add the code as is for now. Such board specific
> routines
> > > can be added later on when really needed.
> >
> > Nope. If the original version of the code contained this support, it
> > makes no sense to me to actively remove it now and add additional
> > effort later to re-add it.
>
> As stated above this ADS addition is not a "clean" one. So there is effort
> necessary to make it acceptable. And as I also stated the driver works
> without
> this code just fine and the ADS. At least my tests didn't show any
> problems.
>
> Best regards,
> Stefan
>
> =====================================================================
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
> =====================================================================
>