[U-Boot] [PATCH] nand/mpc512x: Add MPC512x NAND support (NFC)

Wolfgang Denk
2009-06-08T19:46:08Z

Dear Stefan,

In message <200906082024.25415.sr@denx.de> you wrote:
>
> Did you actually see the code? Did you see the board specific code added to
> the "common" NFC driver code? This is not really something I like to see in
> common drivers. And such code usually get's a NAK from you as well.

No, I didn't check that code.

Hm... but then we need a clean way to implement this - in U-Boot and
Linux.

> As stated above this ADS addition is not a "clean" one. So there is effort
> necessary to make it acceptable. And as I also stated the driver works without
> this code just fine and the ADS. At least my tests didn't show any problems.

What exactly did you test? Did your tests include (for example)
reading and writing to a file system on NAND?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
At the source of every error which is blamed on the computer you will
find at least two human errors, including the error of blaming it on
the computer.