[U-Boot] [PATCH] nand/mpc512x: Add MPC512x NAND support (NFC)

Stefan Roese
2009-06-09T07:31:35Z

Hi Wolfgang,

On Monday 08 June 2009 21:46:08 Wolfgang Denk wrote:
> > Did you actually see the code? Did you see the board specific code added
> > to the "common" NFC driver code? This is not really something I like to
> > see in common drivers. And such code usually get's a NAK from you as
> > well.
>
> No, I didn't check that code.
>
> Hm... but then we need a clean way to implement this - in U-Boot and
> Linux.

ACK. But please note that the scope of my current project is not support NAND
on MPC5121ADS, but on esd MECP5123. MPC5121ADS support can be added in a clean
way later on.

> > As stated above this ADS addition is not a "clean" one. So there is
> > effort necessary to make it acceptable. And as I also stated the driver
> > works without this code just fine and the ADS. At least my tests didn't
> > show any problems.
>
> What exactly did you test? Did your tests include (for example)
> reading and writing to a file system on NAND?

I used "nand read/write" for testing.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================