[U-Boot] [PATCH] nand/mpc512x: Add MPC512x NAND support (NFC)

Wolfgang Denk
2009-06-08T18:08:21Z

Dear Stefan Roese,

In message <200906081900.52451.sr@denx.de> you wrote:
>
> > I do not see ADS5121 support in posted driver code. ADS5121 board controls
> > NAND chip selects via external CPLD and do not use controller chip select
> > signals. Linux driver has workaround for this special case.
>
> Yes, I know. I explicitly removed this code because of two reasons:

Argh. That's a really stupid thing to do.

> a) My basic testing platform was the esd mecp5123 board.
>
> b) I did some quick tests on the MCP5121ADS with this code (without
> this ADS specific chip-select handling) and didn't see any error.
>
> So I suggest to add the code as is for now. Such board specific routines can
> be added later on when really needed.

Nope. If the original version of the code contained this support, it
makes no sense to me to actively remove it now and add additional
effort later to re-add it.

Please undo that removal.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Lots of people drink from the wrong bottle sometimes.
-- Edith Keeler, "The City on the Edge of Forever",
stardate unknown