From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Mon, 8 Jun 2009 20:24:25 +0200 Subject: [U-Boot] [PATCH] nand/mpc512x: Add MPC512x NAND support (NFC) In-Reply-To: <20090608180821.D3A46832E416@gemini.denx.de> References: <1244447475-13692-1-git-send-email-sr@denx.de> <200906081900.52451.sr@denx.de> <20090608180821.D3A46832E416@gemini.denx.de> Message-ID: <200906082024.25415.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 08 June 2009 20:08:21 Wolfgang Denk wrote: > > > I do not see ADS5121 support in posted driver code. ADS5121 board > > > controls NAND chip selects via external CPLD and do not use controller > > > chip select signals. Linux driver has workaround for this special case. > > > > Yes, I know. I explicitly removed this code because of two reasons: > > Argh. That's a really stupid thing to do. Did you actually see the code? Did you see the board specific code added to the "common" NFC driver code? This is not really something I like to see in common drivers. And such code usually get's a NAK from you as well. > > a) My basic testing platform was the esd mecp5123 board. > > > > b) I did some quick tests on the MCP5121ADS with this code (without > > this ADS specific chip-select handling) and didn't see any error. > > > > So I suggest to add the code as is for now. Such board specific routines > > can be added later on when really needed. > > Nope. If the original version of the code contained this support, it > makes no sense to me to actively remove it now and add additional > effort later to re-add it. As stated above this ADS addition is not a "clean" one. So there is effort necessary to make it acceptable. And as I also stated the driver works without this code just fine and the ADS. At least my tests didn't show any problems. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================