[U-Boot] [PATCH] mpc512x: Add esd gmbh mecp5123 board support

[Stefan Roese <sr@denx.de>]

Hi Wolfgang,

On Monday 08 June 2009 20:14:33 Wolfgang Denk wrote:
> Dear Stefan,
>
> In message <200906081937.02354.sr@denx.de> you wrote:
> > > > +	out_be32(&im->mddrc.lut_table4_alternate_upper,
> > > > CONFIG_SYS_MDDRCGRP_LUT4_AU);
> > > > +	out_be32(&im->mddrc.lut_table4_alternate_lower,
> > > > CONFIG_SYS_MDDRCGRP_LUT4_AL);
> > >
> > > Lines too long.
> >
> > OK. Some is true for aria and mcp5121ads btw. But I'll change it in the
> > next patch version.
>
> If you argument that the too long lines are easier to read then the
> wrapped ones, I will not fight about this :-)

Yes, sometimes I really prefer these "too long lines" because it's just better 
readable. I'll keep this code part as is then. :)

> > > How long does it to boot with such an environment in EEPROM?
> >
> > Quite long. About 10 seconds to the U-Boot prompt.
>
> He. And then try "setenv baudrate 115200 ; saveenv" and measure again.

About 6 seconds.

> Does your customer really want to release such a product to his
> customers? Other boards boot in a fraction of that time.

I know. I asked again. Please accept the EEPROM decision for now.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================